feat: add new group for dart #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
setup-dart
branch
from
241f5da to
7e8cb00
Compare
thomaspoignant
requested review from
toddbaert
and removed request for
DavidPHirsch
thomaspoignant
commented
Nov 21, 2024
| @@ -0,0 +1,8 @@ | |||
| repos: | |||
| - dart-sdk-server | |||
There was a problem hiding this comment.
This repo name is a proposal.
There was a problem hiding this comment.
Yes sounds even better, I will rename it 👌
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
|
I am not sure why the CI is failing with the error @aepfli any idea on what can go wrong? |
This happens just on PRs that add teams because the rely on the team to exist to add people to it - it's expected but we add teams so rarely we have never addressed it. When you merge this it should work fine. I (and I think you?) can force merge it anyway and it will work on |
toddbaert
approved these changes
Nov 21, 2024
|
@toddbaert alright got it, I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Following our community meeting here is the new group to prepare contributors for dart sdk server.