Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not send targeting key as separate trait in flagsmith #120

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix: do not send targeting key as separate trait in flagsmith #120

merged 2 commits into from
Dec 21, 2023

Conversation

vpetrusevici
Copy link
Contributor

This PR

  • Removes targeting key (identity) from traits list to avoid unnecessary duplication

@vpetrusevici vpetrusevici requested a review from a team as a code owner December 21, 2023 14:20
Vladimir Petrusevici added 2 commits December 21, 2023 16:22
do not send targeting key as separate trait in flagsmith
cff6251 
Signed-off-by: Vladimir Petrusevici <V.Petrusevici@maib.md>
fix tests
5a6bee7 
Signed-off-by: Vladimir Petrusevici <V.Petrusevici@maib.md>
@vpetrusevici vpetrusevici force-pushed the do-not-send-targeting-key-as-trait branch from ddd69da to 5a6bee7 Compare December 21, 2023 14:23
askpt
askpt approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This has a lot of casts but the EvaluationContext doesn't expose a method to remove a key.

@toddbaert toddbaert merged commit 0725f8f into open-feature:main Dec 21, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
luizbon pushed a commit to prospa-group-oss/dotnet-sdk-contrib that referenced this pull request Dec 21, 2023
@vpetrusevici @luizbon
fix: do not send targeting key as separate trait in flagsmith (open-f…
7b1a329 
…eature#120)

Signed-off-by: Vladimir Petrusevici <V.Petrusevici@maib.md>
Signed-off-by: Luiz Bon <luiz.bon@prospa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askpt askpt askpt approved these changes

@toddbaert toddbaert toddbaert approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees

@matthewelwell matthewelwell

@vpetrusevici vpetrusevici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpetrusevici @askpt @toddbaert @matthewelwell