Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Statsing provider #163

Merged
merged 4 commits into from
Mar 13, 2024
Merged

feat: Statsing provider #163

merged 4 commits into from
Mar 13, 2024

Conversation

jenshenneberg
Copy link
Contributor

@jenshenneberg jenshenneberg commented Mar 5, 2024

This PR

  • Adding a minimal Statsig provider integration

Notes

The implementation is minimal - only ResolveBooleanValue is implemented.

How to test

Create a free Statsig account and use as described in README.md

@jenshenneberg jenshenneberg changed the title Statsing provider feat: Statsing provider Mar 5, 2024
Signed-off-by: Jens Henneberg <jens.henneberg@phocassoftware.com>
Signed-off-by: Jens Henneberg <jens.henneberg@phocassoftware.com>
@jenshenneberg jenshenneberg marked this pull request as ready for review March 7, 2024 22:57
@jenshenneberg jenshenneberg requested a review from a team as a code owner March 7, 2024 22:57
@jenshenneberg jenshenneberg removed their assignment Mar 7, 2024
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. I left a few comments but I think we can merge this when you're ready.

@jenshenneberg
Copy link
Contributor Author

jenshenneberg commented Mar 12, 2024

Thanks for having a look. 😄 I'll do some more testing and wait for a decision on a new release of https://github.com/open-feature/dotnet-sdk/ before merging.

Signed-off-by: Jens Henneberg <jens.henneberg@phocassoftware.com>
@jenshenneberg
Copy link
Contributor Author

Updated to OpenFeature 1.5.* as part of this PR. Please merge this PR if you feel it's ready. Thanks for your input and help with this. 😃

Signed-off-by: Jens Henneberg <jens.henneberg@phocassoftware.com>
@beeme1mr beeme1mr merged commit 98028e9 into open-feature:main Mar 13, 2024
8 checks passed
@jenshenneberg jenshenneberg removed their assignment Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants