Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Central Package Management (CPM) #178

Merged

Conversation

austindrenski
Copy link
Member

@austindrenski austindrenski commented Jan 16, 2024

@austindrenski austindrenski requested a review from a team as a code owner January 16, 2024 19:19
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a7e98d) 93.50% compared to head (d54d11c) 94.11%.
Report is 1 commits behind head on main.

❗ Current head d54d11c differs from pull request most recent head 6cc408b. Consider uploading reports for the commit 6cc408b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   93.50%   94.11%   +0.61%     
==========================================
  Files          23       23              
  Lines         954      951       -3     
  Branches      105      101       -4     
==========================================
+ Hits          892      895       +3     
+ Misses         38       32       -6     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

austindrenski added a commit to austindrenski/open-feature-dotnet-sdk-contrib that referenced this pull request Jan 16, 2024
See: open-feature/dotnet-sdk#178

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk-contrib that referenced this pull request Jan 16, 2024
See: open-feature/dotnet-sdk#178

Signed-off-by: Austin Drenski <austin@austindrenski.io>
@austindrenski austindrenski force-pushed the central-package-management branch 4 times, most recently from ade713d to f9f9c1f Compare January 16, 2024 20:34
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk-contrib that referenced this pull request Jan 16, 2024
See: open-feature/dotnet-sdk#178

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk-contrib that referenced this pull request Jan 16, 2024
See: open-feature/dotnet-sdk#178

Signed-off-by: Austin Drenski <austin@austindrenski.io>
Copy link
Member

@benjiro benjiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All for enabling CPM it makes it much easier to manage deps, nice work. Left a couple of comments about cleaning up some test deps that probably shouldn't be there i know you didn't add them but while your changing it may as well clean them up

Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Show resolved Hide resolved
Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austindrenski austindrenski self-assigned this Jan 18, 2024
@austindrenski austindrenski force-pushed the central-package-management branch 2 times, most recently from 62bcb0a to 82d8542 Compare January 22, 2024 16:55
Signed-off-by: Austin Drenski <austin@austindrenski.io>
@toddbaert toddbaert merged commit 249a0a8 into open-feature:main Jan 26, 2024
8 of 9 checks passed
@austindrenski austindrenski deleted the central-package-management branch January 26, 2024 20:58
askpt pushed a commit that referenced this pull request Jan 30, 2024
Signed-off-by: Austin Drenski <austin@austindrenski.io>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
beeme1mr pushed a commit that referenced this pull request Mar 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](v1.4.1...v1.5.0)
(2024-03-12)


### 🐛 Bug Fixes

* Add targeting key
([#231](#231))
([d792b32](d792b32))
* Fix NU1009 reference assembly warning
([#222](#222))
([7eebcdd](7eebcdd))
* invalid editorconfig
([#244](#244))
([3c00757](3c00757))


### ✨ New Features

* Flag metadata
([#223](#223))
([fd0a541](fd0a541))
* implement in-memory provider
([#232](#232))
([1082094](1082094))


### 🧹 Chore

* bump spec version badge
([#246](#246))
([ebf5552](ebf5552))
* cleanup unused usings 🧹
([#240](#240))
([cdc1bee](cdc1bee))
* **deps:** update actions/upload-artifact action to v4.3.0
([#203](#203))
([0a7e98d](0a7e98d))
* **deps:** update actions/upload-artifact action to v4.3.1
([#233](#233))
([cfaf1c8](cfaf1c8))
* **deps:** update codecov/codecov-action action to v3.1.5
([#209](#209))
([a509b1f](a509b1f))
* **deps:** update codecov/codecov-action action to v3.1.6
([#226](#226))
([a577a80](a577a80))
* **deps:** update dependency coverlet.collector to v6.0.1
([#238](#238))
([f2cb67b](f2cb67b))
* **deps:** update dependency fluentassertions to v6.12.0
([#215](#215))
([2c237df](2c237df))
* **deps:** update dependency microsoft.net.test.sdk to v17.8.0
([#216](#216))
([4cb3ae0](4cb3ae0))
* **deps:** update dependency nsubstitute to v5.1.0
([#217](#217))
([3be76cd](3be76cd))
* **deps:** update dependency openfeature.contrib.providers.flagd to
v0.1.8 ([#211](#211))
([c1aece3](c1aece3))
* **deps:** update xunit-dotnet monorepo
([#236](#236))
([fa25ece](fa25ece))
* Enable Central Package Management (CPM)
([#178](#178))
([249a0a8](249a0a8))
* Enforce coding styles on build
([#242](#242))
([64699c8](64699c8))
* More sln cleanup
([#206](#206))
([bac3d94](bac3d94))
* SourceLink is built-in for .NET SDK 8.0.100+
([#198](#198))
([45e2c86](45e2c86))
* Sync ci.yml with contrib repo
([#196](#196))
([130654b](130654b))
* Sync release.yml with ci.yml following
[#173](#173)
([#195](#195))
([eba8848](eba8848))


### 📚 Documentation

* fix hook ecosystem link
([#229](#229))
([cc6c404](cc6c404))
* update the feature table key
([f8724cd](f8724cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants