fix: Fix ArgumentOutOfRangeException for empty hooks #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: dotnet/runtime#62121, dotnet/runtime#62126 Signed-off-by: Austin Drenski <austin@austindrenski.io>
|
Confirmed failure in CI (as expected):
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 94.73% 94.11% -0.63%
==========================================
Files 23 23
Lines 931 951 +20
Branches 93 101 +8
==========================================
+ Hits 882 895 +13
- Misses 29 32 +3
- Partials 20 24 +4 ☔ View full report in Codecov by Sentry. |
|
Confirmed patch success in CI (as expected):
|
austindrenski
added a commit
to austindrenski/open-feature-dotnet-sdk
that referenced
this pull request
Jan 17, 2024
toddbaert
reviewed
Jan 17, 2024
toddbaert
reviewed
Jan 17, 2024
10 tasks
Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski
force-pushed
the
no-op-push-pop
branch
from
ea53e98 to
db49121
Compare
austindrenski
added a commit
to austindrenski/open-feature-dotnet-sdk
that referenced
this pull request
Jan 17, 2024
toddbaert
approved these changes
Jan 17, 2024
austindrenski
added a commit
to austindrenski/open-feature-dotnet-sdk
that referenced
this pull request
Jan 17, 2024
austindrenski
added a commit
to austindrenski/open-feature-dotnet-sdk
that referenced
this pull request
Jan 19, 2024
arttonoyan
pushed a commit
to arttonoyan/dotnet-sdk
that referenced
this pull request
Nov 17, 2024
Signed-off-by: Austin Drenski <austin@austindrenski.io> Signed-off-by: Artyom Tonoyan <artonoyan@servicetitan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled into this one while working on #186 (while working on #181).
See: dotnet/runtime#62121, dotnet/runtime#62126