Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add github action to perform release #39

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

benjiro
Copy link
Member

@benjiro benjiro commented Aug 7, 2022

This action will trigger when a new tag is push match {major}.{minor}.{patch}
semver format.

This that need to be setup

@codecov-commenter
Copy link

Codecov Report

Merging #39 (f10a620) into main (5937bb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files          15       15           
  Lines         303      303           
  Branches       24       24           
=======================================
  Hits          301      301           
  Partials        2        2           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one question about tag prefixes but it's minor. I'll approve and let you decide what approach makes the most sense.

It's worth noting that the Nuget API token is only valid for one year. I'll sent a calendar reminder for myself to rotate the token before it expires.

.github/workflows/release-package.yml Outdated Show resolved Hide resolved
benjiro and others added 2 commits August 9, 2022 20:33
This action will trigger when a new tag is push match {major}.{minor}.{patch}
semver format.

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
@benjiro benjiro merged commit 3477070 into main Aug 9, 2022
@beeme1mr beeme1mr deleted the chore/add-release-script branch August 9, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants