Basic flag evaluation support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't needed, everything will be contained in the one csproj for now Signed-off-by: Benjamin Evenson <benjamin.evenson@loanmarketgroup.com>
Signed-off-by: Benjamin Evenson <benjamin.evenson@loanmarketgroup.com>
benjiro
force-pushed
the
feat/basic-flag-evluation
branch
from
e7c8173
to
c48a782
Compare
|
I've seen this and plan on taking a close look in the next 2 days while I'm travelling! Thank you @benjiro |
toddbaert
approved these changes
Jun 30, 2022
src/OpenFeature/OpenFeatureClient.cs
Outdated
Comment on lines
61
to
78
| /*var allHooks = new List<IHook>() | ||
| .Concat(OpenFeature.GetHooks()) | ||
| .Concat(_hooks) | ||
| .ToList(); | ||
|
|
||
| var allHooksReversed = allHooks | ||
| .AsEnumerable() | ||
| .Reverse() | ||
| .ToList(); | ||
|
|
||
| var hookContext = new HookContext<bool>( | ||
| flagKey, | ||
| defaultValue, | ||
| FlagValueType.Boolean, | ||
| _metadata, | ||
| OpenFeature.GetProviderMetadata(), | ||
| context | ||
| );*/ |
There was a problem hiding this comment.
Looks like this is commented on purpose, b/c you haven't implemented hooks, yet, but just commenting to make sure you didn't mean to remove it.
There was a problem hiding this comment.
Yea I got through implementing hooks and decided I should just get the basics done first. Ill rebase and remove this out for now
toddbaert
reviewed
Jun 30, 2022
Implement the most basic version of the specification. Signed-off-by: Benjamin Evenson <benjamin.evenson@loanmarketgroup.com>
Signed-off-by: Benjamin Evenson <benjamin.evenson@loanmarketgroup.com>
benjiro
force-pushed
the
feat/basic-flag-evluation
branch
from
c48a782
to
9f1d990
Compare
|
I'm going to move this PR forwards, so I can open the PR for hooks + context |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3
This PR implements the most basic form of the specification to allow retrival of string, number, boolean and structured flags.
Note this is a barebones start, IE I haven't Async'd anything yet