Rework EvaluationContext to use Structure type #53
Conversation
- Adds `Structure` type which represents JSON data - Adds `Value` wrapper class that houses the supported types (Structure, List, bool, int, double, Value) - `EvaluationContext` exposes methods to interact with its underlying keyvalue pairs of string, `Value` - Update interfaces to use `Structure` instead of generics Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Accidentally removed coverlet.msbuild which is needed to codecov Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
benjiro
force-pushed
the
feat/improve-ec-interactions
branch
from
f5b9c26
to
86c8cdb
Compare
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=========================================
+ Coverage 0 93.56% +93.56%
=========================================
Files 0 18 +18
Lines 0 404 +404
Branches 0 33 +33
=========================================
+ Hits 0 378 +378
- Misses 0 18 +18
- Partials 0 8 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
benjiro
changed the title
|
PSA: I'm going to bring this one home at the request of @benjiro (thanks for doing most of the work already!) |
toddbaert
force-pushed
the
feat/improve-ec-interactions
branch
from
8216524
to
40e03a4
Compare
toddbaert
changed the title
Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
force-pushed
the
feat/improve-ec-interactions
branch
from
40e03a4
to
8dfb571
Compare
|
@kinyoklion I would like your take on this relevant issue if you have a moment, I've come to value your input 😅 |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
|
@benjiro @kinyoklion I've added changes analogous to open-feature/java-sdk#61 here as well. |
I thought I got them all. Can you point out any I missed? @kinyoklion EDIT: Oh, I see, some params are missed. I will get those. Thanks! |
|
Not a problem exactly, but this does allow for circular references. I assume that would be a "Just don't do that." Just thinking through if a provider would need to handle that situation. |
Ya, good point. I've seen similar issues with some vendor's SDKs as well, especially converting circular objects to JSON in javascript. It might be worth noting somewhere, maybe even in our general documentation. I will update the param comments and merge. I think we should delay a release for a while though, since I think we may have one more breaking change related to: open-feature/spec#138 |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
doc mention: open-feature/docs.openfeature.dev#110 |
Born from the discussions in #25 and open-feature/java-sdk#50
Structuretype which represents JSON dataValuewrapper class that houses the supported types (Structure, List, bool, int, double, Value - note ints are stored and doubles, and rounded when returned)EvaluationContextexposes methods to interact with its underlying keyvalue pairs of string,ValueStructureinstead of generics