Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: add structure->value, object value constructor #57

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 9, 2022

A c# flavored version of: open-feature/java-sdk#65. I hope these are the last breaking changes before a 1.0rc.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #57 (9f8bdf5) into main (2768d4c) will decrease coverage by 0.29%.
The diff coverage is 67.85%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   94.73%   94.44%   -0.30%     
==========================================
  Files          18       18              
  Lines         418      432      +14     
  Branches       33       36       +3     
==========================================
+ Hits          396      408      +12     
  Misses         13       13              
- Partials        9       11       +2     
Impacted Files Coverage Δ
src/OpenFeature.SDK/FeatureProvider.cs 100.00% <ø> (ø)
src/OpenFeature.SDK/NoOpProvider.cs 100.00% <ø> (ø)
src/OpenFeature.SDK/OpenFeatureClient.cs 99.21% <ø> (ø)
src/OpenFeature.SDK/Model/Value.cs 75.67% <67.85%> (+6.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert changed the title add structure->value, object value constructor BREAKING: add structure->value, object value constructor Sep 9, 2022
@benjiro benjiro added the breaking-change Changes in exposed interfaces or behaviour label Sep 9, 2022
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes in exposed interfaces or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants