-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename OpenFeature class to API and ns to OpenFeature #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to reuse the OpenFeature namespace we need to make sure no classes/structs are named OpenFeature Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
benjiro
force-pushed
the
feat/rename-to-api
branch
from
October 15, 2022 22:34
0238e63
to
af7bc70
Compare
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 20 20
Lines 530 530
Branches 37 37
=======================================
Hits 501 501
Misses 16 16
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
changed the title
feat! rename OpenFeature class to API and ns to OpenFeature
feat!: rename OpenFeature class to API and ns to OpenFeature
Oct 15, 2022
beeme1mr
changed the title
feat!: rename OpenFeature class to API and ns to OpenFeature
refactor!: rename OpenFeature class to API and ns to OpenFeature
Oct 15, 2022
toddbaert
changed the title
refactor!: rename OpenFeature class to API and ns to OpenFeature
feat!: rename OpenFeature class to API and ns to OpenFeature
Oct 16, 2022
Signed-off-by: Todd Baert <toddbaert@gmail.com>
I pushed a commit to fix some formatting errors failing the CI. |
toddbaert
approved these changes
Oct 16, 2022
toddbaert
pushed a commit
that referenced
this pull request
Oct 16, 2022
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2022-10-16) ### ⚠ BREAKING CHANGES * rename OpenFeature class to API and ns to OpenFeature (#82) ### Features * rename OpenFeature class to API and ns to OpenFeature ([#82](#82)) ([6090bd9](6090bd9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
To make it easier to reuse the OpenFeature namespace, we need to ensure no classes/structs are named OpenFeature.
This is a breaking change we want to make before hitting 1.0
Related Issues
Fixes #1234523
Notes
Follow-up Tasks
How to test