Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename OpenFeature class to API and ns to OpenFeature #82

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

benjiro
Copy link
Member

@benjiro benjiro commented Oct 15, 2022

This PR

To make it easier to reuse the OpenFeature namespace, we need to ensure no classes/structs are named OpenFeature.

This is a breaking change we want to make before hitting 1.0

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

@benjiro benjiro requested a review from toddbaert October 15, 2022 22:31
To make it easier to reuse the OpenFeature namespace we need to make
sure no classes/structs are named OpenFeature

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #82 (2ab7708) into main (8b738da) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          20       20           
  Lines         530      530           
  Branches       37       37           
=======================================
  Hits          501      501           
  Misses         16       16           
  Partials       13       13           
Impacted Files Coverage Δ
src/OpenFeature/Constant/Reason.cs 100.00% <ø> (ø)
src/OpenFeature/Error/FeatureProviderException.cs 100.00% <ø> (ø)
src/OpenFeature/Extension/EnumExtensions.cs 80.00% <ø> (ø)
...enFeature/Extension/ResolutionDetailsExtensions.cs 100.00% <ø> (ø)
src/OpenFeature/FeatureProvider.cs 100.00% <ø> (ø)
src/OpenFeature/Hook.cs 100.00% <ø> (ø)
src/OpenFeature/Model/ClientMetadata.cs 100.00% <ø> (ø)
src/OpenFeature/Model/EvaluationContext.cs 77.27% <ø> (ø)
src/OpenFeature/Model/EvaluationContextBuilder.cs 90.90% <ø> (ø)
src/OpenFeature/Model/FlagEvaluationDetails.cs 100.00% <ø> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr beeme1mr changed the title feat! rename OpenFeature class to API and ns to OpenFeature feat!: rename OpenFeature class to API and ns to OpenFeature Oct 15, 2022
@beeme1mr beeme1mr changed the title feat!: rename OpenFeature class to API and ns to OpenFeature refactor!: rename OpenFeature class to API and ns to OpenFeature Oct 15, 2022
@toddbaert toddbaert changed the title refactor!: rename OpenFeature class to API and ns to OpenFeature feat!: rename OpenFeature class to API and ns to OpenFeature Oct 16, 2022
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
Copy link
Member

I pushed a commit to fix some formatting errors failing the CI.

@toddbaert toddbaert merged commit 6090bd9 into main Oct 16, 2022
toddbaert pushed a commit that referenced this pull request Oct 16, 2022
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.0...v0.5.0)
(2022-10-16)


### ⚠ BREAKING CHANGES

* rename OpenFeature class to API and ns to OpenFeature (#82)

### Features

* rename OpenFeature class to API and ns to OpenFeature
([#82](#82))
([6090bd9](6090bd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants