feat: resolve-all functionality #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
force-pushed
the
feat/bulk-eval
branch
from
4114aad to
59c06e1
Compare
toddbaert
commented
Dec 18, 2022
protobuf/schema/v1/schema.proto
Outdated
Comment on lines
37
to
43
| oneof value { | ||
| bool boolValue = 3; | ||
| string stringValue = 4; | ||
| int64 intValue = 5; | ||
| double doubleValue = 6; | ||
| google.protobuf.Struct objectValue = 7; | ||
| } |
There was a problem hiding this comment.
I think oneof is a good solution here. In many languages it generates some convenience functions so we can easily check what value is set.
toddbaert
commented
Dec 18, 2022
protobuf/schema/v1/schema.proto
Outdated
|
|
||
| // The response value of the boolean flag evaluation, will be unset in the case of error. | ||
| oneof value { | ||
| bool boolValue = 3; |
There was a problem hiding this comment.
linting errors here as boolValue should instead be lower snake cased bool_value, same with the other names
Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
changed the title
|
Looks good to me - but going to hold off on approving until I play around with what a map of |
💯 , yep, that was my only mild concern too. I thought it seemed like a nice implementation but it'd be good to have that validated. Thanks! |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
james-milligan
approved these changes
Dec 20, 2022
|
LGTM :) |
james-milligan
pushed a commit
that referenced
this pull request
Dec 20, 2022
🤖 I have created a release *beep* *boop* --- ## [0.2.6](v0.2.5...v0.2.6) (2022-12-20) ### Features * resolve-all functionality ([#62](#62)) ([9ca9ee3](9ca9ee3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #63