Skip to content

Commit

Permalink
fix: remove dep cycle with certreloader (#1410)
Browse files Browse the repository at this point in the history
#1389 works well but caused a
dependency cycle: core -> flagd -> core.

I've moved the `certreloader` pkg to core with the existing telemetry
stuff.

cc @kevinschoonover

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
  • Loading branch information
toddbaert authored Sep 23, 2024
1 parent 8737f53 commit 5244f6f
Show file tree
Hide file tree
Showing 5 changed files with 109 additions and 4,546 deletions.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion core/pkg/telemetry/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

"connectrpc.com/connect"
"connectrpc.com/otelconnect"
"github.com/open-feature/flagd/core/pkg/certreloader"
"github.com/open-feature/flagd/core/pkg/logger"
"github.com/open-feature/flagd/flagd/pkg/certreloader"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace"
Expand Down
Loading

0 comments on commit 5244f6f

Please sign in to comment.