Skip to content

Commit

Permalink
ci: set homebrew download URL (#346)
Browse files Browse the repository at this point in the history 
## This PR

- Adds a `download-url` to the Homebrew release action

### Related Issues

Fixes #345 

### Notes

The bump homebrew formula action takes an optional download url. By
setting this value to a git-based URL, the action should update the tag
and reversion.

https://github.com/mislav/bump-homebrew-formula-action#how-it-works

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
  • Loading branch information
@beeme1mr
beeme1mr authored Feb 2, 2023
1 parent 541589b commit 7cb20d9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/release-please.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ jobs:
with:
formula-name: flagd
tag-name: ${{ needs.release-please.outputs.release_tag_name }}
download-url: https://github.com/${{ github.repository }}.git
commit-message: |
{{formulaName}} {{version}}
Expand Down

1 comment on commit 7cb20d9

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 7cb20d9 Previous: a767627 Ratio
BenchmarkResolveBooleanValue/test_targetingBoolFlag 18390 ns/op 4817 B/op 80 allocs/op 11660 ns/op 4801 B/op 80 allocs/op 1.58
BenchmarkResolveBooleanValue/test_missingFlag 1734 ns/op 160 B/op 6 allocs/op 1309 ns/op 144 B/op 6 allocs/op 1.32
BenchmarkResolveBooleanValue/test_disabledFlag 1741 ns/op 160 B/op 6 allocs/op 1305 ns/op 144 B/op 6 allocs/op 1.33
BenchmarkResolveStringValue/test_staticStringFlag 1655 ns/op 128 B/op 6 allocs/op 1272 ns/op 128 B/op 6 allocs/op 1.30
BenchmarkResolveStringValue/test_targetingStringFlag 18388 ns/op 4841 B/op 82 allocs/op 11578 ns/op 4841 B/op 82 allocs/op 1.59
BenchmarkResolveIntValue/test_staticIntFlag 1577 ns/op 96 B/op 4 allocs/op 1207 ns/op 96 B/op 4 allocs/op 1.31
BenchmarkResolveIntValue/test_targetingNumberFlag 16708 ns/op 4825 B/op 80 allocs/op 10607 ns/op 4825 B/op 80 allocs/op 1.58
BenchmarkResolveObjectValue/test_staticObjectFlag 6461 ns/op 1392 B/op 32 allocs/op 4516 ns/op 1392 B/op 32 allocs/op 1.43
BenchmarkResolveObjectValue/test_targetingObjectFlag 22816 ns/op 6106 B/op 104 allocs/op 15131 ns/op 6106 B/op 104 allocs/op 1.51
BenchmarkConnectService_ResolveObject/happy_path 6574 ns/op 1872 B/op 34 allocs/op 4804 ns/op 1856 B/op 34 allocs/op 1.37

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.