fix: bubbles up unclean error exits (#170)

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

#169

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

cmd/start.go

@@ -93,8 +93,12 @@ var startCmd = &cobra.Command{
 		})
 		if err != nil {
 			log.Error(err)
+			os.Exit(1)
 		}
 
-		rt.Start()
+		if err := rt.Start(); err != nil {
+			log.Error(err)
+			os.Exit(1)
+		}
 	},
 }

pkg/runtime/start.go

@@ -2,25 +2,23 @@ package runtime
 
 import (
 	"context"
+	"errors"
 	"os"
 	"os/signal"
 	"syscall"
 
 	"golang.org/x/sync/errgroup"
 )
 
-func (r *Runtime) Start() {
+func (r *Runtime) Start() error {
 	if r.Service == nil {
-		r.Logger.Error("no Service set")
-		return
+		return errors.New("no Service set")
 	}
 	if len(r.SyncImpl) == 0 {
-		r.Logger.Error("no SyncImplementation set")
-		return
+		return errors.New("no SyncImplementation set")
 	}
 	if r.Evaluator == nil {
-		r.Logger.Error("no Evaluator set")
-		return
+		return errors.New("no Evaluator set")
 	}
 
 	ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
@@ -40,6 +38,7 @@ func (r *Runtime) Start() {
 
 	<-gCtx.Done()
 	if err := g.Wait(); err != nil {
-		r.Logger.Error(err)
+		return err
 	}
+	return nil
 }