refactor: remove unused struct field (#458)

<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- removes unused struct field in filepath sync

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

---------

Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>

pkg/sync/file/filepath_sync.go

@@ -18,7 +18,6 @@ import (
 
 type Sync struct {
 	URI          string
-	Source       string
 	Logger       *logger.Logger
 	ProviderArgs sync.ProviderArgs
 	// FileType indicates the file type e.g., json, yaml/yml etc.,
@@ -134,7 +133,7 @@ func (fs *Sync) sendDataSync(ctx context.Context, syncType sync.Type, dataSync c
 		}
 	}
 
-	dataSync <- sync.DataSync{FlagData: msg, Source: fs.Source, Type: syncType}
+	dataSync <- sync.DataSync{FlagData: msg, Source: fs.URI, Type: syncType}
 }
 
 func (fs *Sync) fetch(_ context.Context) (string, error) {

pkg/sync/file/filepath_sync_test.go

@@ -39,7 +39,6 @@ func TestSimpleReSync(t *testing.T) {
 	handler := Sync{
 		URI:    fmt.Sprintf("%s/%s", fetchDirName, fetchFileName),
 		Logger: logger.NewLogger(nil, false),
-		Source: fmt.Sprintf("%s/%s", fetchDirName, fetchFileName),
 	}
 
 	for test, tt := range tests {
@@ -152,7 +151,6 @@ func TestSimpleSync(t *testing.T) {
 					URI:    fmt.Sprintf("%s/%s", fetchDirName, fetchFileName),
 					Logger: logger.NewLogger(nil, false),
 					Mux:    &msync.RWMutex{},
-					Source: fmt.Sprintf("%s/%s", fetchDirName, fetchFileName),
 				}
 				err := handler.Init(ctx)
 				if err != nil {

pkg/sync/grpc/grpc_sync.go

@@ -34,6 +34,7 @@ type Sync struct {
 	Target     string
 	ProviderID string
 	Logger     *logger.Logger
+
 	syncClient syncv1grpc.FlagSyncService_SyncFlagsClient
 	client     syncv1grpc.FlagSyncServiceClient
 	options    []grpc.DialOption

pkg/sync/http/http_sync.go

@@ -23,7 +23,8 @@ type Sync struct {
 	LastBodySHA  string
 	Logger       *logger.Logger
 	ProviderArgs sync.ProviderArgs
-	ready        bool
+
+	ready bool
 }
 
 // Client defines the behaviour required of a http client

pkg/sync/kubernetes/kubernetes_sync.go

@@ -32,7 +32,6 @@ type Sync struct {
 	ProviderArgs sync.ProviderArgs
 	URI          string
 
-	Source     string
 	ready      bool
 	namespace  string
 	crdName    string
@@ -45,7 +44,7 @@ func (k *Sync) ReSync(ctx context.Context, dataSync chan<- sync.DataSync) error
 	if err != nil {
 		return err
 	}
-	dataSync <- sync.DataSync{FlagData: fetch, Source: k.Source, Type: sync.ALL}
+	dataSync <- sync.DataSync{FlagData: fetch, Source: k.URI, Type: sync.ALL}
 	return nil
 }
 
@@ -100,7 +99,7 @@ func (k *Sync) Sync(ctx context.Context, dataSync chan<- sync.DataSync) error {
 		return err
 	}
 
-	dataSync <- sync.DataSync{FlagData: fetch, Source: k.Source, Type: sync.ALL}
+	dataSync <- sync.DataSync{FlagData: fetch, Source: k.URI, Type: sync.ALL}
 
 	notifies := make(chan INotify)
 
@@ -139,7 +138,7 @@ func (k *Sync) watcher(ctx context.Context, notifies chan INotify, dataSync chan
 					continue
 				}
 
-				dataSync <- sync.DataSync{FlagData: msg, Source: k.Source, Type: sync.ALL}
+				dataSync <- sync.DataSync{FlagData: msg, Source: k.URI, Type: sync.ALL}
 			case DefaultEventTypeModify:
 				k.Logger.Debug("Configuration modified")
 				msg, err := k.fetch(ctx)
@@ -148,7 +147,7 @@ func (k *Sync) watcher(ctx context.Context, notifies chan INotify, dataSync chan
 					continue
 				}
 
-				dataSync <- sync.DataSync{FlagData: msg, Source: k.Source, Type: sync.ALL}
+				dataSync <- sync.DataSync{FlagData: msg, Source: k.URI, Type: sync.ALL}
 			case DefaultEventTypeDelete:
 				k.Logger.Debug("configuration deleted")
 			case DefaultEventTypeReady: