fix tests

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
open-feature · Apr 3, 2023 · df43c8f · df43c8f
1 parent 67f15a6
commit df43c8f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/core/pkg/service/flag-evaluation/flag_evaluator.go b/core/pkg/service/flag-evaluation/flag_evaluator.go
@@ -162,7 +162,7 @@ func resolve[T constraints](
 		zap.Strings("context-keys", formatContextKeys(ctx)),
 	)
 
-	var evalErrFormatted error = nil
+	var evalErrFormatted error
 	result, variant, reason, evalErr := resolver(reqID, flagKey, ctx)
 	if evalErr != nil {
 		logger.WarnWithID(reqID, fmt.Sprintf("returning error response, reason: %v", evalErr))

diff --git a/core/pkg/service/flag-evaluation/flag_evaluator_test.go b/core/pkg/service/flag-evaluation/flag_evaluator_test.go
@@ -160,7 +160,7 @@ func TestFlag_Evaluation_ResolveBoolean(t *testing.T) {
 			wantErr: nil,
 		},
 		"eval returns error": {
-			mCount: 0,
+			mCount: 1,
 			evalFields: resolveBooleanEvalFields{
 				result:  true,
 				variant: ":(",
@@ -307,7 +307,7 @@ func TestFlag_Evaluation_ResolveString(t *testing.T) {
 			wantErr: nil,
 		},
 		"eval returns error": {
-			mCount: 0,
+			mCount: 1,
 			evalFields: resolveStringEvalFields{
 				result:  "true",
 				variant: ":(",
@@ -454,7 +454,7 @@ func TestFlag_Evaluation_ResolveFloat(t *testing.T) {
 			wantErr: nil,
 		},
 		"eval returns error": {
-			mCount: 0,
+			mCount: 1,
 			evalFields: resolveFloatEvalFields{
 				result:  12,
 				variant: ":(",
@@ -601,7 +601,7 @@ func TestFlag_Evaluation_ResolveInt(t *testing.T) {
 			wantErr: nil,
 		},
 		"eval returns error": {
-			mCount: 0,
+			mCount: 1,
 			evalFields: resolveIntEvalFields{
 				result:  12,
 				variant: ":(",
@@ -750,7 +750,7 @@ func TestFlag_Evaluation_ResolveObject(t *testing.T) {
 			wantErr: nil,
 		},
 		"eval returns error": {
-			mCount: 0,
+			mCount: 1,
 			evalFields: resolveObjectEvalFields{
 				result: map[string]interface{}{
 					"food": "bars",