Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make flagd independent of go sdk provider #1004

Closed
Kavindu-Dodan opened this issue Nov 13, 2023 · 1 comment · Fixed by #1005
Closed

[FEATURE] Make flagd independent of go sdk provider #1004

Kavindu-Dodan opened this issue Nov 13, 2023 · 1 comment · Fixed by #1005
Labels
enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer

Comments

@Kavindu-Dodan
Copy link
Contributor

Requirements

Right now our e2e tests rely on go sdk provider to execute e2e tests. Given these test definitions are located under flagd, go.mod will have a dependency on the go provider. This creates a circular dependency between flagd & flagd go provider

graph TD;
    flagd --> go-sdk-provider;
   go-sdk-provider -->  flagd;
Loading

We need to remove this dependency by ideally isolating e2e tests to dedicated package so that flagd go.mod becomes isolated.

@Kavindu-Dodan Kavindu-Dodan added enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer labels Nov 13, 2023
@Kavindu-Dodan
Copy link
Contributor Author

There's a direct dependency from integration tests to go flagd provider. Given flagd provider internally use flagd core, this creates a circular dependency that's harder to resolve. Further, given that we use a go workspace, it's impossible to maintain e2e tests only dependencies locally.

toddbaert added a commit that referenced this issue Nov 15, 2023
## This PR

Attempts to fix #1004

---------

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant