Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Sign release images #328

Closed
beeme1mr opened this issue Jan 26, 2023 · 0 comments · Fixed by #338
Closed

[FEATURE] Sign release images #328

beeme1mr opened this issue Jan 26, 2023 · 0 comments · Fixed by #338
Assignees
@Kavindu-Dodan
Labels
enhancement New feature or request security

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Jan 26, 2023 •
edited by toddbaert

Requirements

The flagd image should be signed by something like cosign during the release process. This is already being in the in the operator and a similar flow can be used here.

https://github.com/open-feature/open-feature-operator/blob/main/.github/workflows/release-please.yml#L86-L99
@beeme1mr beeme1mr added enhancement New feature or request security labels Jan 26, 2023
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Jan 27, 2023
Merged
@PB-TW PB-TW mentioned this issue Feb 1, 2023
Closed
toddbaert pushed a commit that referenced this issue Feb 1, 2023
@Kavindu-Dodan
feat: flagd image signing (#338)
eca6a60 
## This PR

fixes #328

Introduce image signing for flagd. Signature is pushed to OCR repository
and public key will get added to release artefacts under the name
`publicKey.pub` (referred through variable PUBLIC_KEY_FILE in GH action)

**NOTE** - Require COSIGN_PRIVATE_KEY & COSIGN_PASSWORD secrets to be
created. And decide how to expose public key

---------

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kavindu-Dodan Kavindu-Dodan

Labels
enhancement New feature or request security
Projects
☁ Cloud Native
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: flagd image signing Kavindu-Dodan/flagd
2 participants
@beeme1mr @Kavindu-Dodan