Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add version to startup message #430

Merged

Conversation

joaoepj
Copy link

@joaoepj joaoepj commented Feb 23, 2023

This PR

  • adds version to flagd startup message

Related Issues

Fixes #428

Notes

Running flagd from main branch:
...

2023-02-23T17:44:37.503-0300 info file/filepath_sync.go:32 Starting filepath sync notifier {"component": "sync", "sync": "filepath"}
2023-02-23T17:44:37.503-0300 info service/connect_service.go:110 metrics listening at 8014 {"component": "service"}
...

Running flagd from this PR branch:
...

2023-02-23T17:47:26.504-0300 info cmd/start.go:97 flagd version: dev (15ef000), built at: 2023-02-23T17:47:20Z {"component": "start"}
2023-02-23T17:47:26.504-0300 info file/filepath_sync.go:32 Starting filepath sync notifier {"component": "sync", "sync": "filepath"}
...

@joaoepj joaoepj changed the title Adding version to startup message feat: Adding version to startup message Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #430 (12da94c) into main (5a6a5d5) will not change coverage.
The diff coverage is n/a.

❗ Current head 12da94c differs from pull request most recent head 38ffb33. Consider uploading reports for the commit 38ffb33 to get more accurate results

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files          11       11           
  Lines        1325     1325           
=======================================
  Hits          847      847           
  Misses        428      428           
  Partials       50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr
Copy link
Member

Hey @joaoepj, thanks for the PR! Would you mind signing off on your commit? If you're unfamiliar with DCO, you can read about it here. It's a requirements from the CNCF that all commits have been signed off by the author.

To add your Signed-off-by line to every commit in this branch:

  • Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  • In your local branch, run: git rebase HEAD~1 --signoff
  • Force push your changes to overwrite the branch: git push --force-with-lease origin include-version-in-startup-message

@beeme1mr beeme1mr changed the title feat: Adding version to startup message feat: Add version to startup message Feb 24, 2023
@beeme1mr
Copy link
Member

The integration test failure is a known problem and should be resolved early next week. I also don't think the drop in code coverage is an issue in this case. We should be good to go once there's enough approvals and the DCO check has passed.

Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally and in my view fulfill the tasks need.

@joaoepj joaoepj force-pushed the include-version-in-startup-message branch from 15ef000 to a947bac Compare February 25, 2023 23:26
@joaoepj
Copy link
Author

joaoepj commented Feb 25, 2023

Hey @joaoepj, thanks for the PR! Would you mind signing off on your commit? If you're unfamiliar with DCO, you can read about it here. It's a requirements from the CNCF that all commits have been signed off by the author.

To add your Signed-off-by line to every commit in this branch:

  • Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  • In your local branch, run: git rebase HEAD~1 --signoff
  • Force push your changes to overwrite the branch: git push --force-with-lease origin include-version-in-startup-message

Thank you @beeme1mr, the commit was signed off!

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with all the above comments. We don't need coverage for this :)

I will get this merged after rebasing on the integration test fixes.

Signed-off-by: Joao E Pereira Jr <joaoepj@gmail.com>
@toddbaert toddbaert force-pushed the include-version-in-startup-message branch from 12da94c to 38ffb33 Compare February 27, 2023 19:17
@toddbaert toddbaert merged commit 8daf613 into open-feature:main Feb 27, 2023
@toddbaert
Copy link
Member

Merged. Thanks @joaoepj for your contribution!

beeme1mr pushed a commit that referenced this pull request Mar 2, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](v0.3.7...v0.4.0)
(2023-03-02)


### ⚠ BREAKING CHANGES

* Use OTel to export metrics (metric name changes)
([#419](#419))

### 🧹 Chore

* add additional sections to the release notes
([#449](#449))
([798f71a](798f71a))
* attach image sbom to release artefacts
([#407](#407))
([fb4ee50](fb4ee50))
* **deps:** update actions/configure-pages digest to fc89b04
([#417](#417))
([04014e7](04014e7))
* **deps:** update amannn/action-semantic-pull-request digest to b6bca70
([#441](#441))
([ce0ebe1](ce0ebe1))
* **deps:** update docker/login-action digest to ec9cdf0
([#437](#437))
([2650670](2650670))
* **deps:** update docker/metadata-action digest to 3343011
([#438](#438))
([e7ebf32](e7ebf32))
* **deps:** update github/codeql-action digest to 32dc499
([#439](#439))
([f91d91b](f91d91b))
* **deps:** update google-github-actions/release-please-action digest to
d3c71f9 ([#406](#406))
([6e1ffb2](6e1ffb2))
* disable caching tests in CI
([#442](#442))
([28a35f6](28a35f6))
* fix race condition on init read
([#409](#409))
([0c9eb23](0c9eb23))
* integration test stability
([#432](#432))
([5a6a5d5](5a6a5d5))
* integration tests
([#312](#312))
([6192ac8](6192ac8))
* reorder release note sections
([df7bfce](df7bfce))
* use -short flag in benchmark tests
([#431](#431))
([e68a6aa](e68a6aa))


### 🐛 Bug Fixes

* **deps:** update kubernetes packages to v0.26.2
([#450](#450))
([2885227](2885227))
* **deps:** update module github.com/bufbuild/connect-go to v1.5.2
([#416](#416))
([feb7f04](feb7f04))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.9
([#427](#427))
([42d2705](42d2705))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.29 ([#429](#429))
([b7fae81](b7fae81))
* **deps:** update module github.com/stretchr/testify to v1.8.2
([#440](#440))
([ab3e674](ab3e674))
* **deps:** update module golang.org/x/net to v0.7.0
([#410](#410))
([c6133b6](c6133b6))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.5
([#454](#454))
([f907f11](f907f11))
* remove non-error error log from parseFractionalEvaluationData
([#446](#446))
([34aca79](34aca79))


### ✨ New Features

* add debug logging for merge behaviour
([#456](#456))
([dc71e84](dc71e84))
* add Health and Readiness probes
([#418](#418))
([7f2358c](7f2358c))
* Add version to startup message
([#430](#430))
([8daf613](8daf613))
* introduce flag merge behaviour
([#414](#414))
([524f65e](524f65e))
* introduce grpc sync for flagd
([#297](#297))
([33413f2](33413f2))
* refactor and improve K8s sync provider
([#443](#443))
([4c03bfc](4c03bfc))
* Use OTel to export metrics (metric name changes)
([#419](#419))
([eb3982a](eb3982a))


### 📚 Documentation

* add .net flagd provider
([73d7840](73d7840))
* configuration merge docs
([#455](#455))
([6cb66b1](6cb66b1))
* documentation for creating a provider
([#413](#413))
([d0c099d](d0c099d))
* updated filepaths for schema store regex
([#344](#344))
([2d0e9d9](2d0e9d9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Include the version in the startup message
5 participants