fix: eventing configuration setup #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
fix/eventing-configurations
branch
from
5775362 to
00326c6
Compare
Codecov Report
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 71.05% 71.66% +0.60%
==========================================
Files 22 23 +1
Lines 2277 2287 +10
==========================================
+ Hits 1618 1639 +21
+ Misses 594 583 -11
Partials 65 65
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kavindu-Dodan
requested review from
beeme1mr,
thisthat,
bacherfl and
james-milligan
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
fix/eventing-configurations
branch
from
3c41fc8 to
843af97
Compare
james-milligan
approved these changes
Apr 13, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #603
The root cause of the bug was an incorrect configuration setup. This PR corrects this and performs a refactoring to avoid any such confusion and occurrences.
A minimal unit test is added to validate notify behavior