-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to connectrpc/connect-go #990
refactor: migrate to connectrpc/connect-go #990
Conversation
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
=======================================
Coverage 72.63% 72.63%
=======================================
Files 28 28
Lines 2858 2858
=======================================
Hits 2076 2076
Misses 685 685
Partials 97 97
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
🤔 , maybe this is not as easy as I thought. I can't seem to get rid of
The obvious replacement
does not seem to exist. Edit: I don't think the above is relevant. But the dependency on open-feature/go-sdk-contrib#372 is to pass the integration test. |
Signed-off-by: Craig Pastro <craig.pastro@gmail.com>
1fc05d7
to
8c90d2b
Compare
@craigpastro I rebased on main and resolved conflicts (only in mod/sum files). |
e2e tests have failed, gonna check this now |
This is due to circular dependency. Let's go ahead with the change and update go provider this time - #1004 |
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.8</summary> ## [0.6.8](flagd/v0.6.7...flagd/v0.6.8) (2023-11-13) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.7 ([#966](#966)) ([c038a3a](c038a3a)) * **deps:** update module github.com/open-feature/go-sdk to v1.8.0 ([#994](#994)) ([266cf9f](266cf9f)) * **deps:** update module github.com/open-feature/go-sdk-contrib/tests/flagd to v1.3.1 ([#760](#760)) ([30dda72](30dda72)) * **deps:** update module github.com/spf13/cobra to v1.8.0 ([#993](#993)) ([05c7870](05c7870)) ### 🧹 Chore * fix lint errors ([#987](#987)) ([0c3af2d](0c3af2d)) ### 🔄 Refactoring * migrate to connectrpc/connect-go ([#990](#990)) ([7dd5b2b](7dd5b2b)) </details> <details><summary>flagd-proxy: 0.2.13</summary> ## [0.2.13](flagd-proxy/v0.2.12...flagd-proxy/v0.2.13) (2023-11-13) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.7 ([#966](#966)) ([c038a3a](c038a3a)) * **deps:** update module github.com/spf13/cobra to v1.8.0 ([#993](#993)) ([05c7870](05c7870)) ### 🔄 Refactoring * migrate to connectrpc/connect-go ([#990](#990)) ([7dd5b2b](7dd5b2b)) </details> <details><summary>core: 0.6.8</summary> ## [0.6.8](core/v0.6.7...core/v0.6.8) (2023-11-13) ### 🐛 Bug Fixes * **deps:** update golang.org/x/exp digest to 9a3e603 ([#929](#929)) ([f8db930](f8db930)) * **deps:** update kubernetes packages to v0.28.3 ([#974](#974)) ([d7d205f](d7d205f)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.3.1 ([#971](#971)) ([f1a40b8](f1a40b8)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.3.2 ([#975](#975)) ([b53c14a](b53c14a)) * **deps:** update module github.com/fsnotify/fsnotify to v1.7.0 ([#981](#981)) ([727b9d2](727b9d2)) * **deps:** update module golang.org/x/mod to v0.14.0 ([#991](#991)) ([87bc12d](87bc12d)) * **deps:** update module golang.org/x/net to v0.17.0 [security] ([#963](#963)) ([7f54bd1](7f54bd1)) * **deps:** update module golang.org/x/net to v0.18.0 ([#1000](#1000)) ([e9347cc](e9347cc)) * **deps:** update module golang.org/x/sync to v0.5.0 ([#992](#992)) ([bd24536](bd24536)) * **deps:** update module google.golang.org/grpc to v1.59.0 ([#972](#972)) ([7d0f1f2](7d0f1f2)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.16.3 ([#976](#976)) ([b33c9c9](b33c9c9)) * **deps:** update opentelemetry-go monorepo ([#1001](#1001)) ([9798aeb](9798aeb)) ### 🔄 Refactoring * migrate to connectrpc/connect-go ([#990](#990)) ([7dd5b2b](7dd5b2b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Migrate from bufbuild/connect-go to connectrpc/connect-go.
Related Issues
Closes #790.
Notes
Follow-up Tasks
I'll also create a PR in https://github.com/open-feature/go-sdk-contrib to migrate to connectrpc/connect-go for the flagd provider.
How to test