Adding HTTPS support for flagd #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexsJones
force-pushed
the
feature/https
branch
from
0374d5e
to
92f2f71
Compare
beeme1mr
requested review from
james-milligan,
toddbaert and
thomaspoignant
and removed request for
james-milligan and
toddbaert
AlexsJones
force-pushed
the
feature/https
branch
from
a3b780f
to
6ec3f6f
Compare
|
Ive tested the grpc connection with flagd set to http/https and it works as expected - unable to connect with insecure dial credentials, but able to connect using the correct certificates 👍 |
AlexsJones
force-pushed
the
feature/https
branch
from
f95f9ad
to
14b9566
Compare
beeme1mr
reviewed
Aug 4, 2022
AlexsJones
force-pushed
the
feature/https
branch
from
f11256e
to
8f69c81
Compare
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: James-Milligan <james@omnant.co.uk> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: James-Milligan <james@omnant.co.uk> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: James-Milligan <james@omnant.co.uk> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Alex Jones <alex.jones@canonical.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Alex Jones <alex.jones@canonical.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
AlexsJones
force-pushed
the
feature/https
branch
from
8f69c81
to
491a77b
Compare
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
james-milligan
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the ability to use TLS with flagD as reported #97
It introduces two new parameters on the
startcommandThese can be pointed to
pem/crt/keyfiles.Example is
flagd start -c server-crt.pem -k server-key.pem