fix: invalid scoped-sync responses for empty flags #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Kavindu-Dodan
approved these changes
Jul 5, 2024
aepfli
approved these changes
Jul 5, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
fix/bad-sync-response-with-scopes
branch
from
efbfa9a
to
8a7e186
Compare
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jul 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.11.1</summary> ## [0.11.1](flagd/v0.11.0...flagd/v0.11.1) (2024-07-08) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.4.0-20240215170432-1e611e2999cc.2 ([#1342](#1342)) ([efdd921](efdd921)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.0 ([#1340](#1340)) ([1e487b4](1e487b4)) * **deps:** update module golang.org/x/net to v0.27.0 ([#1353](#1353)) ([df9834b](df9834b)) * **deps:** update module google.golang.org/grpc to v1.65.0 ([#1346](#1346)) ([72a6b87](72a6b87)) * **deps:** update opentelemetry-go monorepo ([#1347](#1347)) ([37fb3cd](37fb3cd)) * invalid scoped-sync responses for empty flags ([#1352](#1352)) ([51371d2](51371d2)) </details> <details><summary>flagd-proxy: 0.6.4</summary> ## [0.6.4](flagd-proxy/v0.6.3...flagd-proxy/v0.6.4) (2024-07-08) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.4.0-20240215170432-1e611e2999cc.2 ([#1342](#1342)) ([efdd921](efdd921)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.0 ([#1340](#1340)) ([1e487b4](1e487b4)) * **deps:** update module golang.org/x/net to v0.27.0 ([#1353](#1353)) ([df9834b](df9834b)) * **deps:** update module google.golang.org/grpc to v1.65.0 ([#1346](#1346)) ([72a6b87](72a6b87)) * **deps:** update opentelemetry-go monorepo ([#1347](#1347)) ([37fb3cd](37fb3cd)) </details> <details><summary>core: 0.10.1</summary> ## [0.10.1](core/v0.10.0...core/v0.10.1) (2024-07-08) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.4.0-20240215170432-1e611e2999cc.2 ([#1342](#1342)) ([efdd921](efdd921)) * **deps:** update module golang.org/x/crypto to v0.25.0 ([#1351](#1351)) ([450cbc8](450cbc8)) * **deps:** update module golang.org/x/mod to v0.19.0 ([#1349](#1349)) ([6ee89b4](6ee89b4)) * **deps:** update module google.golang.org/grpc to v1.65.0 ([#1346](#1346)) ([72a6b87](72a6b87)) * **deps:** update opentelemetry-go monorepo ([#1347](#1347)) ([37fb3cd](37fb3cd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where invalid flag payloads were returned on sync requests with scopes if the flag set was empty.
Below is an example of the bug.
$ grpcurl -import-path /home/todd/temp -proto sync.proto -plaintext localhost:8015 flagd.sync.v1.FlagSyncService/FetchAllFlags { "flagConfiguration": "{\"flags\":{}}" } $ grpcurl -import-path /home/todd/temp -proto sync.proto -plaintext -d '{"selector":"../config/samples/example_flags.flagd.json"}' localhost:8015 flagd.sync.v1.FlagSyncService/FetchAllFlags {}