chore: improve gRPC sync service shutdown behavior #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
dosubot
bot
added
the
size:XS
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
beeme1mr
approved these changes
Aug 2, 2024
Merged
beeme1mr
pushed a commit
that referenced
this pull request
Aug 22, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.11.2</summary> ## [0.11.2](flagd/v0.11.1...flagd/v0.11.2) (2024-08-22) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.5.1-20240215170432-1e611e2999cc.1 ([#1372](#1372)) ([ae24595](ae24595)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.1 ([#1355](#1355)) ([8fcfb14](8fcfb14)) * **deps:** update module golang.org/x/net to v0.28.0 ([#1380](#1380)) ([239a432](239a432)) * **deps:** update module golang.org/x/sync to v0.8.0 ([#1378](#1378)) ([4804c17](4804c17)) ### 🧹 Chore * **deps:** update dependency go to v1.22.6 ([#1297](#1297)) ([50b92c1](50b92c1)) * **deps:** update golang docker tag to v1.23 ([#1382](#1382)) ([abb5ca3](abb5ca3)) * improve gRPC sync service shutdown behavior ([#1375](#1375)) ([79d9085](79d9085)) </details> <details><summary>flagd-proxy: 0.6.5</summary> ## [0.6.5](flagd-proxy/v0.6.4...flagd-proxy/v0.6.5) (2024-08-22) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.5.1-20240215170432-1e611e2999cc.1 ([#1372](#1372)) ([ae24595](ae24595)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.1 ([#1355](#1355)) ([8fcfb14](8fcfb14)) * **deps:** update module golang.org/x/net to v0.28.0 ([#1380](#1380)) ([239a432](239a432)) * **deps:** update module golang.org/x/sync to v0.8.0 ([#1378](#1378)) ([4804c17](4804c17)) ### 🧹 Chore * **deps:** update dependency go to v1.22.6 ([#1297](#1297)) ([50b92c1](50b92c1)) * **deps:** update golang docker tag to v1.23 ([#1382](#1382)) ([abb5ca3](abb5ca3)) ### 📚 Documentation * **flagd-proxy:** removed invalid grpc prefix from uri config ([4911697](4911697)) </details> <details><summary>core: 0.10.2</summary> ## [0.10.2](core/v0.10.1...core/v0.10.2) (2024-08-22) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.5.1-20240215170432-1e611e2999cc.1 ([#1372](#1372)) ([ae24595](ae24595)) * **deps:** update module connectrpc.com/otelconnect to v0.7.1 ([#1367](#1367)) ([184915b](184915b)) * **deps:** update module github.com/open-feature/open-feature-operator/apis to v0.2.44 ([#1368](#1368)) ([0c68726](0c68726)) * **deps:** update module golang.org/x/crypto to v0.26.0 ([#1379](#1379)) ([05f6658](05f6658)) * **deps:** update module golang.org/x/mod to v0.20.0 ([#1377](#1377)) ([797d7a4](797d7a4)) * **deps:** update module golang.org/x/sync to v0.8.0 ([#1378](#1378)) ([4804c17](4804c17)) ### ✨ New Features * add 'watcher' interface to file sync ([#1365](#1365)) ([61fff43](61fff43)) * added new grpc sync config option to allow setting max receive message size. ([#1358](#1358)) ([bed077b](bed077b)) * Support blob type sources and GCS as an example of such source. ([#1366](#1366)) ([21f2c9a](21f2c9a)) ### 🧹 Chore * **deps:** update dependency go to v1.22.6 ([#1297](#1297)) ([50b92c1](50b92c1)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Address the discussion #1373
The root cause is the listener closing (
Close()), which is already done through grpc server.Stop()