Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkout release tag before running container and binary releases #171

Merged
merged 2 commits into from
Sep 23, 2022
Merged

fix: checkout release tag before running container and binary releases #171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea63833
checkout release tag before running container and binary releases
beeme1mr Sep 23, 2022
8a9849c
Merge branch 'main' into fix/release-please-artifact-upload
beeme1mr Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v3
with:
submodules: recursive
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
ref: ${{ needs.release-please.outputs.release_tag_name }}

- name: Log in to the Container registry
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ needs.release-please.outputs.release_tag_name }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
VERSION=${{ steps.meta.outputs.tags }}
VERSION=${{ needs.release-please.outputs.release_tag_name }}
COMMIT=${{ github.sha }}
DATE=${{ steps.date.outputs.date }}

Expand All @@ -82,6 +82,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ needs.release-please.outputs.release_tag_name }}

- name: Set up Go
uses: actions/setup-go@v3
Expand Down