Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: snap #211

Merged
merged 6 commits into from
Nov 22, 2022
Merged

feat: snap #211

merged 6 commits into from
Nov 22, 2022

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Nov 18, 2022 •
edited by beeme1mr
Loading

Adding snap configuration and badge

@AlexsJones AlexsJones marked this pull request as ready for review November 18, 2022 08:59
@AlexsJones AlexsJones changed the title feat/snap feat: snap Nov 18, 2022
beeme1mr
beeme1mr reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does Snap pick up the changes?

@beeme1mr beeme1mr linked an issue Nov 21, 2022 that may be closed by this pull request
Add FlagD to Snap #209
Closed
toddbaert
toddbaert approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know very little about snaps, but I certainly trust @AlexsJones to, given his associations!

Along with @beeme1mr, I'm unsure how snapcraft.io "knows" about this package given there's no publish CI or anything here. Is snapcraft.io configured to look at the yaml file in this repo periodically?

@beeme1mr beeme1mr self-requested a review November 22, 2022 01:29
beeme1mr
beeme1mr approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this looks good. I would just like to understand the process a bit.

Thanks for putting this together @AlexsJones!

@AlexsJones
Copy link
Member Author

Agreed, this looks good. I would just like to understand the process a bit.

Thanks for putting this together @AlexsJones!

Currently this is adding in the settings for publishing, the publishing itself is still manual at this point e.g. you have to be logged in and run snapcraft what I will do is add a bit of documentation on how to manually release until we automate it

skyerus and others added 5 commits November 22, 2022 21:03
@skyerus @AlexsJones
chore: contributing section for the docs (#202)
feede32 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Alex <alexsimonjones@gmail.com>
@AlexsJones
adding snap configuration and badge
e66e54b 
Signed-off-by: Alex <alexsimonjones@gmail.com>
@AlexsJones
updated release please
b7a18e4 
Signed-off-by: Alex <alexsimonjones@gmail.com>
@AlexsJones
higher quality remote image url
bbc6249 
Signed-off-by: Alex <alexsimonjones@gmail.com>
@AlexsJones
updated docs
4077acc 
Signed-off-by: Alex <alexsimonjones@gmail.com>
@AlexsJones AlexsJones merged commit c619844 into main Nov 22, 2022
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Merged
@AlexsJones AlexsJones deleted the feat/snap branch November 22, 2022 21:07
AlexsJones pushed a commit that referenced this pull request Dec 5, 2022
@github-actions
chore(main): release 0.2.7 (#215)
df7c6ee 
🤖 I have created a release *beep* *boop*
---


##
[0.2.7](v0.2.5...v0.2.7)
(2022-12-02)


### ⚠ BREAKING CHANGES

* start command flag refactor
([#222](#222))

### Features

* enable request logging via the --debug flag
([#226](#226))
([11954b5](11954b5))
* Resurrected the STATIC flag reason. Documented the caching strategy.
([#224](#224))
([5830592](5830592))
* snap ([#211](#211))
([c619844](c619844))
* start command flag refactor
([#222](#222))
([14474cc](14474cc))


### Miscellaneous Chores

* release v0.2.6
([93cfb78](93cfb78))
* release v0.2.7
([4a9f6df](4a9f6df))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-milligan james-milligan james-milligan approved these changes

@skyerus skyerus skyerus approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FlagD to Snap
5 participants
@AlexsJones @beeme1mr @toddbaert @skyerus @james-milligan