Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add architecture overview for recent refactoring #310

Merged
merged 7 commits into from
Jan 30, 2023
Merged

chore: add architecture overview for recent refactoring #310

merged 7 commits into from
Jan 30, 2023

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jan 23, 2023 •
edited
Loading

This PR

Adds a component diagram for flag configuration providers and their interactions with the runtime and other systems.

Related PR #291

@Kavindu-Dodan
add architecture overview for recent refactoring
f046a2e 
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan
add description and change header
9f6e638 
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@toddbaert
Copy link
Member

I find the label "ISync Impl Listner" (sp) a bit misleading, probable because in code/comments, we refer to it something like "DataSync channel watcher"... That is what this represents, right? I think that might be a better name. Or just "DataSync Channel"? I think we should choose a consistent name for this abstraction.

@Kavindu-Dodan
Copy link
Contributor Author

I find the label "ISync Impl Listner" (sp) a bit misleading, probable because in code/comments, we refer to it something like "DataSync channel watcher"... That is what this represents, right? I think that might be a better name. Or just "DataSync Channel"? I think we should choose a consistent name for this abstraction.

I agree with this. I will rephrase this to "DataSync channel listener"

@toddbaert toddbaert merged commit a114070 into open-feature:main Jan 30, 2023
@toddbaert
Copy link
Member

@Kavindu-Dodan I meant to ask this before merge, but forgot... can you also commit the excalidraw source?

@Kavindu-Dodan Kavindu-Dodan mentioned this pull request Jan 30, 2023
Merged
toddbaert pushed a commit that referenced this pull request Jan 30, 2023
@Kavindu-Dodan
chore: Image source for image (#348)
0391848 
## This PR

Adds the image source content of the PR
#310. Source can be used with
**excalidraw**

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-milligan james-milligan james-milligan approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@AlexsJones AlexsJones Awaiting requested review from AlexsJones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kavindu-Dodan @toddbaert @beeme1mr @james-milligan