Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce additional linting rules + fix discrepancies #616

Merged
merged 19 commits into from
Jun 7, 2023
Merged

refactor: introduce additional linting rules + fix discrepancies #616

merged 19 commits into from
Jun 7, 2023

Conversation

james-milligan
Copy link
Contributor

@james-milligan james-milligan commented Apr 14, 2023 •
edited
Loading

This PR

  • extends the scope of linting
  • fixes all linting issues for the new scope

Related Issues

Notes

Follow-up Tasks

How to test

@james-milligan
extend linting
5a0789f 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
fix linting gci
a3395de 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fix durationcheck
a9c874f 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fix wrapcheck
94c5c27 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
remove ireturn
781fe12 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fix nilerr
86c494c 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fix exhaustive
e816f6c 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
ignore contextcheck in sync store (requires stored context)
5fdf854 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fixes
60a2cd8 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fixes wrapcheck
d0f6e26 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan requested a review from a team as a code owner April 14, 2023 13:24
@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #616 (fde4853) into main (5060a0e) will increase coverage by 0.77%.
The diff coverage is 72.09%.

❗ Current head fde4853 differs from pull request most recent head ec5a10c. Consider uploading reports for the commit ec5a10c to get more accurate results

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   72.77%   73.55%   +0.77%     
==========================================
  Files          24       26       +2     
  Lines        2384     2575     +191     
==========================================
+ Hits         1735     1894     +159     
- Misses        583      609      +26     
- Partials       66       72       +6
Impacted Files Coverage Δ
core/pkg/logger/logger.go 22.38% <0.00%> (-0.69%) ⬇️
core/pkg/runtime/runtime.go 0.00% <0.00%> (ø)
core/pkg/store/flags.go 81.15% <0.00%> (ø)
core/pkg/sync-store/sync_store.go 87.43% <0.00%> (-1.88%) ⬇️
core/pkg/sync/http/http_sync.go 43.29% <0.00%> (ø)
...ore/pkg/service/flag-evaluation/connect_service.go 69.28% <10.00%> (-1.52%) ⬇️
...ore/pkg/service/middleware/metrics/http_metrics.go 70.45% <20.00%> (-5.80%) ⬇️
core/pkg/runtime/from_config.go 56.35% <25.00%> (ø)
core/pkg/telemetry/builder.go 69.07% <33.33%> (-6.23%) ⬇️
core/pkg/service/flag-evaluation/flag_evaluator.go 78.26% <50.00%> (+4.12%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kavindu-Dodan
Copy link
Contributor

@james-milligan seems this PR is going out of sync with upstream. Can you resync and see if this is still relevant?

@james-milligan
merge
72f4519 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
cleanup
1d1c69a 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
Merge branch 'linting' of https://github.com/james-milligan/flagd int…
cc7b1ea 
…o linting
@james-milligan
removed duplicated import
fde4853 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
linting fixes
ec5a10c 
Signed-off-by: James Milligan <james@omnant.co.uk>
Kavindu-Dodan
Kavindu-Dodan approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - I like the error wrapping as it gives more context in logs

@beeme1mr beeme1mr merged commit aef0b90 into open-feature:main Jun 7, 2023
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Merged
beeme1mr pushed a commit that referenced this pull request Jun 7, 2023
@github-actions
chore: release main (#643)
f3fbe6d 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.5.4</summary>

##
[0.5.4](flagd/v0.5.3...flagd/v0.5.4)
(2023-06-07)


### 🧹 Chore

* update otel dependencies
([#649](#649))
([2114e41](2114e41))


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.5.3
([#634](#634))
([1bc7e99](1bc7e99))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.12
([#635](#635))
([fe88061](fe88061))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/tests/flagd to v1.2.2
([#651](#651))
([9776973](9776973))


### ✨ New Features

* telemetry improvements
([#653](#653))
([ea02cba](ea02cba))


### 🔄 Refactoring

* introduce additional linting rules + fix discrepancies
([#616](#616))
([aef0b90](aef0b90))
</details>

<details><summary>flagd-proxy: 0.2.4</summary>

##
[0.2.4](flagd-proxy/v0.2.3...flagd-proxy/v0.2.4)
(2023-06-07)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.5.3
([#634](#634))
([1bc7e99](1bc7e99))


### 🧹 Chore

* update otel dependencies
([#649](#649))
([2114e41](2114e41))


### ✨ New Features

* telemetry improvements
([#653](#653))
([ea02cba](ea02cba))


### 🔄 Refactoring

* introduce additional linting rules + fix discrepancies
([#616](#616))
([aef0b90](aef0b90))
* introduce isyncstore interface
([#660](#660))
([c0e2fa0](c0e2fa0))
</details>

<details><summary>core: 0.5.4</summary>

##
[0.5.4](core/v0.5.3...core/v0.5.4)
(2023-06-07)


### ✨ New Features

* add `sem_ver` jsonLogic evaluator
([#675](#675))
([a8d8ab6](a8d8ab6))
* add `starts_with` and `ends_with` json evaluators
([#658](#658))
([f932b8f](f932b8f))
* telemetry improvements
([#653](#653))
([ea02cba](ea02cba))


### 🐛 Bug Fixes

* **deps:** update module github.com/bufbuild/connect-go to v1.8.0
([#683](#683))
([13bb13d](13bb13d))
* **deps:** update module github.com/bufbuild/connect-opentelemetry-go
to v0.3.0 ([#669](#669))
([e899435](e899435))
* **deps:** update module github.com/prometheus/client_golang to v1.15.1
([#636](#636))
([b22279d](b22279d))
* **deps:** update module github.com/stretchr/testify to v1.8.3
([#662](#662))
([2e06d58](2e06d58))
* **deps:** update module github.com/stretchr/testify to v1.8.4
([#678](#678))
([ca8c9d6](ca8c9d6))
* **deps:** update module golang.org/x/mod to v0.10.0
([#682](#682))
([16199ce](16199ce))
* **deps:** update module golang.org/x/net to v0.10.0
([#644](#644))
([ccd9d35](ccd9d35))
* **deps:** update module golang.org/x/sync to v0.2.0
([#638](#638))
([7f4a7db](7f4a7db))
* **deps:** update module google.golang.org/grpc to v1.55.0
([#640](#640))
([c0d7328](c0d7328))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.15.0
([#665](#665))
([9490ed6](9490ed6))
* fix connect error code handling for disabled flags
([#670](#670))
([86a8012](86a8012))
* remove disabled flags from bulk evaluation
([#672](#672))
([d2ce988](d2ce988))


### 🔄 Refactoring

* introduce additional linting rules + fix discrepancies
([#616](#616))
([aef0b90](aef0b90))
* introduce isyncstore interface
([#660](#660))
([c0e2fa0](c0e2fa0))


### 🧹 Chore

* refactor json logic evaluator to pass custom operators as options
([#691](#691))
([1c9bff9](1c9bff9))
* update otel dependencies
([#649](#649))
([2114e41](2114e41))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-milligan @Kavindu-Dodan @beeme1mr