Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting rules documentation #93

Merged

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Jul 29, 2022

No description provided.

@skyerus skyerus mentioned this pull request Jul 29, 2022
@beeme1mr
Copy link
Member

This is looks great! I think you should mention that the else section that it can be nil instead of a variant name. When you do that, it would use the default variant.

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus force-pushed the issue-84_targeting-documentation branch from aaa4bbf to fe88d5c Compare July 29, 2022 12:57
@skyerus
Copy link
Contributor Author

skyerus commented Jul 29, 2022

This is looks great! I think you should mention that the else section that it can be nil instead of a variant name. When you do that, it would use the default variant.

Thanks for the suggestion, done!

@AlexsJones AlexsJones merged commit 3771ab5 into open-feature:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants