Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint errors #987

Merged
merged 2 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ run:
skip-dirs:
- (^|/)bin($|/)
- (^|/)examples($|/)
- (^|/)schemas($|/)
- (^|/)test-harness($|/)
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
linters:
enable:
- asciicheck
Expand Down
13 changes: 7 additions & 6 deletions flagd/cmd/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const (
sourcesFlagName = "sources"
syncProviderFlagName = "sync-provider"
uriFlagName = "uri"
docsLinkConfiguration = "https://flagd.dev/reference/flagd-cli/flagd_start/"

defaultServicePort = 8013
defaultMetricsPort = 8014
Expand Down Expand Up @@ -117,18 +118,18 @@ var startCmd = &cobra.Command{
rtLogger.Info(fmt.Sprintf("flagd version: %s (%s), built at: %s", Version, Commit, Date))

if viper.GetString(syncProviderFlagName) != "" {
rtLogger.Warn("DEPRECATED: The --sync-provider flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md")
rtLogger.Warn("DEPRECATED: The --sync-provider flag has been deprecated, see: " +
docsLinkConfiguration)
}

if viper.GetString(evaluatorFlagName) != "json" {
rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md")
rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated, see: " +
docsLinkConfiguration)
}

if viper.GetString(providerArgsFlagName) != "" {
rtLogger.Warn("DEPRECATED: The --sync-provider-args flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md")
rtLogger.Warn("DEPRECATED: The --sync-provider-args flag has been deprecated, see: " +
docsLinkConfiguration)
}

syncProviders, err := runtime.ParseSyncProviderURIs(viper.GetStringSlice(uriFlagName))
Expand Down
Loading