support for float64 and int64 flag values #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
james-milligan
requested review from
AlexsJones,
beeme1mr,
toddbaert and
skyerus
skyerus
reviewed
Aug 4, 2022
Signed-off-by: James-Milligan <james@omnant.co.uk>
AlexsJones
approved these changes
Aug 4, 2022
skyerus
approved these changes
Aug 4, 2022
thomaspoignant
approved these changes
Aug 4, 2022
beeme1mr
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates schema changes to introduce /int and /float endpoints to http interface, and introduces the respective rpcs.
when using int64 the http interface will return a string value, this is due to the proto3 json mapping within grpc-gateway. These changes will be reflected in the golang-sdk-contribs flagd provider.