feat: EvaluationContext add constructor without TargetingKey #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 78.95% 78.99% +0.03%
==========================================
Files 9 9
Lines 1074 1076 +2
==========================================
+ Hits 848 850 +2
Misses 204 204
Partials 22 22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thomaspoignant
changed the title
thomaspoignant
changed the title
beeme1mr
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Thanks @thomaspoignant! I'll update the readme when this is live
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Based on this discussion we have discovered that in some cases we want to create an EvaluationContext without Targeting key.
With
NewEvaluationContextit was mandatory to set atargetingKeyforcing us to set an emptytargetingKeysometimes.In this PR we add a new constructor called
NewTargetlessEvaluationContextthat is doing exactly the same things asNewEvaluationContextbut does not force you to add atargetingKey.