-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logging hook, rm logging from evaluation #289
Conversation
@liran2000 sorry I missed this! I will review today. Looks like there's some CI failures though. |
Thanks, this PR requires GO version to be upgraded to 1.21 before proceeding, hence the failures. |
I've opened: #294 |
@liran2000 thanks so much; sorry for the wait. #289 (comment) is my only question. Approved, but wonder what your thoughts on that are. |
@liran2000 I've merged the Go 1.2.1 change, there's a few lint/CI failures. |
Signed-off-by: liran2000 <liran2000@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 81.89% 82.19% +0.30%
==========================================
Files 10 11 +1
Lines 1215 1219 +4
==========================================
+ Hits 995 1002 +7
+ Misses 199 193 -6
- Partials 21 24 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Thanks again @liran2000 |
Implements: [FEATURE] Implement Logging Hook
This PR removes logging from the main evaluation code path, with a few exceptions, like unhandled errors in event handlers. These cases are printed with default slog.
It also adds a LoggingHook as per the spec link above, using slog.
logr usage is removed, but exported APIs remains for backward compatibility.
Java implementation
Closes: #284
@toddbaert @Kavindu-Dodan