improve test

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
open-feature · Jan 5, 2024 · 78758a2 · 78758a2
1 parent 71a36b4
commit 78758a2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 26 deletions.
diff --git a/...re/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnectorTest.java b/...re/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnectorTest.java
@@ -65,34 +65,12 @@ void emitErrorStateForInvalidPath() throws IOException {
 
     @Test
     void watchForFileUpdatesAndEmitThem() throws IOException {
-        final String initial = "{\n" +
-                "  \"flags\": {\n" +
-                "    \"myBoolFlag\": {\n" +
-                "      \"state\": \"ENABLED\",\n" +
-                "      \"variants\": {\n" +
-                "        \"on\": true,\n" +
-                "        \"off\": false\n" +
-                "      },\n" +
-                "      \"defaultVariant\": \"on\"\n" +
-                "    }\n" +
-                "  }\n" +
-                "}";
-        final String updatedFlags = "{\n" +
-                "  \"flags\": {\n" +
-                "    \"myBoolFlag\": {\n" +
-                "      \"state\": \"ENABLED\",\n" +
-                "      \"variants\": {\n" +
-                "        \"on\": true,\n" +
-                "        \"off\": false\n" +
-                "      },\n" +
-                "      \"defaultVariant\": \"off\"\n" +
-                "    }\n" +
-                "  }\n" +
-                "}";
+        final String initial = "{\"flags\":{\"myBoolFlag\":{\"state\":\"ENABLED\",\"variants\":{\"on\":true,\"off\":false},\"defaultVariant\":\"on\"}}}";
+        final String updatedFlags = "{\"flags\":{\"myBoolFlag\":{\"state\":\"ENABLED\",\"variants\":{\"on\":true,\"off\":false},\"defaultVariant\":\"off\"}}}";
 
         // given
         final Path updPath = Paths.get(getResourcePath(UPDATABLE_FILE));
-        Files.write(updPath, initial.getBytes(), StandardOpenOption.WRITE);
+        Files.write(updPath, initial.getBytes(), StandardOpenOption.WRITE, StandardOpenOption.TRUNCATE_EXISTING);
 
         final FileConnector connector = new FileConnector(updPath.toString());
 
@@ -111,7 +89,7 @@ void watchForFileUpdatesAndEmitThem() throws IOException {
         assertEquals(initial, payload[0].getData());
 
         // then update the flags
-        Files.write(updPath, updatedFlags.getBytes(), StandardOpenOption.WRITE);
+        Files.write(updPath, updatedFlags.getBytes(), StandardOpenOption.WRITE, StandardOpenOption.TRUNCATE_EXISTING);
 
         // finally wait for updated payload
         assertTimeoutPreemptively(Duration.ofSeconds(10), () -> {

diff --git a/providers/flagd/src/test/resources/flagConfigurations/updatableFlags.json b/providers/flagd/src/test/resources/flagConfigurations/updatableFlags.json
@@ -0,0 +1,12 @@
+{
+  "flags": {
+    "myBoolFlag": {
+      "state": "ENABLED",
+      "variants": {
+        "on": true,
+        "off": false
+      },
+      "defaultVariant": "on"
+    }
+  }
+}