fix: javadoc issue in ci

Signed-off-by: Todd Baert <toddbaert@gmail.com>
open-feature · Sep 27, 2022 · 7a10feb · 7a10feb
1 parent bcfc65a
commit 7a10feb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,15 +16,11 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Set up JDK 18
-        if: ${{ steps.release.outputs.releases_created }}
         uses: actions/setup-java@v3
         with:
           java-version: "18"
           distribution: "temurin"
           cache: maven
-          server-id: ossrh
-          server-username: OSSRH_USERNAME
-          server-password: OSSRH_PASSWORD
 
       - name: Cache local Maven repository
         uses: actions/cache@v2
@@ -35,7 +31,4 @@ jobs:
             ${{ runner.os }}-maven-
 
       - name: Maven Verify
-        run: mvn --batch-mode --settings release/m2-settings.xml verify
-        env:
-          OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
-          OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
+        run: mvn --batch-mode clean verify
diff --git a/pom.xml b/pom.xml
@@ -42,6 +42,8 @@
         <maven.compiler.source>1.8</maven.compiler.source>
         <maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
         <junit.jupiter.version>5.8.1</junit.jupiter.version>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     </properties>
 
     <dependencies>
@@ -169,6 +171,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-pmd-plugin</artifactId>
+                <version>3.19.0</version>
                 <configuration>
                     <excludeRoots>${basedir}/target/generated-sources/</excludeRoots>
                 </configuration>
@@ -253,14 +256,18 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
-                <version>3.4.0</version>
+                <version>3.4.1</version>
                 <configuration>
                     <failOnWarnings>true</failOnWarnings>
-                    <excludePackageNames>dev.openfeature.flagd.grpc</excludePackageNames>
+                    <sourceFileExcludes>
+                        <sourceFileExclude>**/GoFeatureFlagProviderOptions.java</sourceFileExclude>
+                    </sourceFileExcludes>
+                    <excludePackageNames>dev.openfeature.flagd.grpc,dev.openfeature.contrib.providers.gofeatureflag.exception,dev.openfeature.contrib.providers.gofeatureflag.bean</excludePackageNames>
                 </configuration>
                 <executions>
                     <execution>
                         <id>attach-javadocs</id>
+                        <phase>verify</phase>
                         <goals>
                             <goal>jar</goal>
                         </goals>