Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-provider implementation #1028

Merged
merged 13 commits into from
Nov 4, 2024
Merged

feat: multi-provider implementation #1028

merged 13 commits into from
Nov 4, 2024

Conversation

liran2000
Copy link
Member

@liran2000 liran2000 commented Oct 21, 2024 •
edited
Loading

Readme describes the provider.

References

@liran2000
add multi-provider
99dc065 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
rename module as failing with - char
cf290bf 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
tests
ecf3a1f 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
updates
dfd1c76 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
updates 2
651bcce 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
updates 3
dbf0c5c 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000 liran2000 requested a review from a team as a code owner October 21, 2024 11:56
@liran2000 liran2000 requested review from aepfli and toddbaert October 21, 2024 11:57
@liran2000
Merge branch 'main' into feature/multi-provider
11d09a5 
Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
aepfli
aepfli reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks really cool. But especially the Strategy initialization and the handling of 'exception-less Errors' might be problematic

...r/src/main/java/dev/openfeature/contrib/providers/multiprovider/FirstSuccessfulStrategy.java Outdated Show resolved Hide resolved
...ovider/src/main/java/dev/openfeature/contrib/providers/multiprovider/FirstMatchStrategy.java Outdated Show resolved Hide resolved
@liran2000
init updates
daeefe9 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
updates
eabbe73 
Signed-off-by: liran2000 <liran2000@gmail.com>
beeme1mr
beeme1mr reviewed Oct 21, 2024
View reviewed changes
providers/multiprovider/CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this changelog. A new one should be created by Release Please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

release-please-config.json Outdated
@@ -100,6 +100,17 @@
"README.md"
]
},
"providers/multi-provider": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file path is providers/multiprovider. Please either update the path name or this configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, originally I had "multi-provider" like other providers, but it failed validation on Invalid Automatic-Module-Name:

❌ no - allowed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would Maven Central allow invalid names to be uploaded?

Copy link
Member

@toddbaert toddbaert Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's because they aren't invalid in other JVM langauges, like Scala or Kotlin, and maven supports all of these.

@liran2000
naming updates
154e846 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
change evaluate signature
ca8d76a 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
update readme usage
476c0bf 
Signed-off-by: liran2000 <liran2000@gmail.com>
toddbaert
toddbaert reviewed Oct 23, 2024
View reviewed changes
...ltiprovider/src/main/java/dev/openfeature/contrib/providers/multiprovider/MultiProvider.java
*/
@Override
public void initialize(EvaluationContext evaluationContext) throws Exception {
JSONObject json = new JSONObject();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of JSON object, could we use a HashMap, or our SDK's own build-in object representation (Structure and it's implementations)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Multi-provider metadata spec, it is expected to be printed as JSON, which makes sense.
Both HashMap and Structure not printed as Json.

toddbaert
toddbaert reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments but overall looks very close.

@liran2000
parallel init
ac693cb 
Signed-off-by: liran2000 <liran2000@gmail.com>
@toddbaert toddbaert requested review from aepfli and beeme1mr October 31, 2024 18:12
@toddbaert toddbaert merged commit df4ad47 into open-feature:main Nov 4, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Open
matheusverissimo pushed a commit to matheusverissimo/java-sdk-contrib that referenced this pull request Nov 6, 2024
@liran2000 @matheusverissimo
feat: multi-provider implementation (open-feature#1028)
c6ff6ba 
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
Signed-off-by: Matheus Veríssimo <rodrigues.verissimo.matheus@gmail.com>
matheusverissimo pushed a commit to matheusverissimo/java-sdk-contrib that referenced this pull request Nov 6, 2024
@liran2000 @matheusverissimo
feat: multi-provider implementation (open-feature#1028)
5a44360 
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
Signed-off-by: Matheus Veríssimo <rodrigues.verissimo.matheus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@aepfli aepfli aepfli approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@liran2000 liran2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liran2000 @beeme1mr @aepfli @toddbaert