feat!: otel metric hook #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
changed the title
Kavindu-Dodan
commented
Jun 8, 2023
toddbaert
reviewed
Jul 6, 2023
...open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OpenTelemetryMetricHook.java
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Jul 6, 2023
hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OpenTelemetryHook.java
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Jul 6, 2023
...open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OpenTelemetryMetricHook.java
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Jul 7, 2023
...open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OpenTelemetryMetricHook.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/otel-metric-hook
branch
from
03531cf
to
ae0def6
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/otel-metric-hook
branch
from
ae0def6
to
d933cd7
Compare
Kavindu-Dodan
changed the title
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/otel-metric-hook
branch
from
7315e80
to
4c6f93d
Compare
|
@toddbaert like you proposed, I have made this a breaking change. Plus refactored by renaming OTel hook classes |
toddbaert
reviewed
Jul 14, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
toddbaert
reviewed
Jul 14, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
toddbaert
approved these changes
Jul 14, 2023
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…e-plugin to v3 (open-feature#332) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #329 by implementing the OTel metrics hook OFEP proposed through open-feature/ofep#62
dev.openfeature.contrib.hooks) version is updated to 2.0.0OpenTelemetryHooktoTracesHookOpenTelemetryHookOptionstoTracesHookOptions