-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hook builder options for dimension extraction #391
Merged
Kavindu-Dodan
merged 6 commits into
open-feature:main
from
Kavindu-Dodan:feat/hook-dimension-callback
Aug 21, 2023
Merged
feat: hook builder options for dimension extraction #391
Kavindu-Dodan
merged 6 commits into
open-feature:main
from
Kavindu-Dodan:feat/hook-dimension-callback
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
force-pushed
the
feat/hook-dimension-callback
branch
from
August 4, 2023 22:43
57b28ff
to
542e8da
Compare
thisthat
reviewed
Aug 7, 2023
hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricHookOptions.java
Show resolved
Hide resolved
thisthat
reviewed
Aug 7, 2023
toddbaert
approved these changes
Aug 17, 2023
thiyagu06
approved these changes
Aug 19, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/hook-dimension-callback
branch
from
August 21, 2023 17:25
396ab41
to
d712dd8
Compare
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #381
Adds callback option to extract custom dimensions from flag evaluation metadata.
This is similar to what we do in JS SDK - open-feature/js-sdk-contrib#520
This change is backward compatible and does not change the current beavhior.