Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Unleash provider #424

Merged
merged 20 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/component_owners.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ components:
- thomaspoignant
providers/jsonlogic-eval-provider:
- justinabrahms
providers/unleash:
- liran2000
toddbaert marked this conversation as resolved.
Show resolved Hide resolved

ignored-authors:
- renovate-bot
3 changes: 2 additions & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"providers/go-feature-flag": "0.2.11",
"providers/flagsmith": "0.0.8",
"providers/env-var": "0.0.4",
"providers/jsonlogic-eval-provider": "1.0.0"
"providers/jsonlogic-eval-provider": "1.0.0",
"providers/unleash": "0.0.1"
}
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<module>providers/go-feature-flag</module>
<module>providers/jsonlogic-eval-provider</module>
<module>providers/env-var</module>
<module>providers/unleash</module>
</modules>

<scm>
Expand Down
Empty file.
54 changes: 54 additions & 0 deletions providers/unleash/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# Unofficial Unleash OpenFeature Provider for Java

Unleash OpenFeature Provider can provide usage for Unleash via OpenFeature Java SDK.

## Installation

<!-- x-release-please-start-version -->

```xml

<dependency>
<groupId>dev.openfeature.contrib.providers</groupId>
<artifactId>unleash</artifactId>
<version>0.0.1</version>
</dependency>
```

<!-- x-release-please-end-version -->

## Concepts
* Boolean evaluation gets feature enabled status.
* String evaluation gets feature variant value.

## Usage
Unleash OpenFeature Provider is using Unleash Java SDK.

### Usage Example

```
FeatureProvider featureProvider = new UnleashProvider(unleashOptions);
OpenFeatureAPI.getInstance().setProviderAndWait(unleashProvider);
boolean featureEnabled = client.getBooleanValue(FLAG_NAME, false);

UnleashContext unleashContext = UnleashContext.builder().userId("1").build();
EvaluationContext evaluationContext = UnleashProvider.transform(unleashContext);
featureEnabled = client.getBooleanValue(FLAG_NAME, false, evaluationContext);

String variantValue = client.getStringValue(FLAG_NAME, "");
```

See [UnleashProviderTest.java](./src/test/java/dev/openfeature/contrib/providers/unleash/UnleashProviderTest.java) for more information.

## Caveats / Limitations

* Unleash OpenFeature Provider only supports boolean and string evaluation.
* Unleash OpenFeature Provider only supports string variant type.

## Unleash Provider Tests Strategies

Unit test based on Unleash instance with Unleash features schema file, with WireMock for API mocking.
See [UnleashProviderTest.java](./src/test/java/dev/openfeature/contrib/providers/unleash/UnleashProviderTest.java) for more information.

## References
* [Unleash](https://getunleash.io)
5 changes: 5 additions & 0 deletions providers/unleash/lombok.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# This file is needed to avoid errors throw by findbugs when working with lombok.
lombok.addSuppressWarnings = true
lombok.addLombokGeneratedAnnotation = true
config.stopBubbling = true
lombok.extern.findbugs.addSuppressFBWarnings = true
47 changes: 47 additions & 0 deletions providers/unleash/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>dev.openfeature.contrib</groupId>
<artifactId>parent</artifactId>
<version>0.1.0</version>
<relativePath>../../pom.xml</relativePath>
</parent>
<groupId>dev.openfeature.contrib.providers</groupId>
<artifactId>unleash</artifactId>
<version>0.0.1</version> <!--x-release-please-version -->

<name>unleash</name>
<description>unleash provider for Java</description>
<url>https://www.getunleash.io/</url>

<dependencies>
<dependency>
<groupId>io.getunleash</groupId>
<artifactId>unleash-client-java</artifactId>
<version>8.3.1</version>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.9</version>
</dependency>

<dependency>
<groupId>com.github.tomakehurst</groupId>
<artifactId>wiremock-jre8</artifactId>
<version>2.35.1</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j2-impl</artifactId>
<version>2.20.0</version>
<scope>test</scope>
</dependency>

</dependencies>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
package dev.openfeature.contrib.providers.unleash;

import dev.openfeature.sdk.EvaluationContext;
import dev.openfeature.sdk.ImmutableContext;
import dev.openfeature.sdk.Value;
import io.getunleash.UnleashContext;

import java.time.ZonedDateTime;
import java.util.HashMap;
import java.util.Map;

/**
* Transformer from Unleash context to OpenFeature context and vice versa.
*/
public class ContextTransformer {

public static final String CONTEXT_APP_NAME = "appName";
public static final String CONTEXT_USER_ID = "userId";
public static final String CONTEXT_ENVIRONMENT = "environment";
public static final String CONTEXT_REMOTE_ADDRESS = "remoteAddress";
public static final String CONTEXT_SESSION_ID = "sessionId";
public static final String CONTEXT_CURRENT_TIME = "currentTime";

protected static UnleashContext transform(EvaluationContext ctx) {
UnleashContext.Builder unleashContextBuilder = new UnleashContext.Builder();
ctx.asObjectMap().forEach((k, v) -> {
switch (k) {
case CONTEXT_APP_NAME:
unleashContextBuilder.appName(String.valueOf(v));
break;
case CONTEXT_USER_ID:
unleashContextBuilder.userId(String.valueOf(v));
break;
case CONTEXT_ENVIRONMENT:
unleashContextBuilder.environment(String.valueOf(v));
break;
case CONTEXT_REMOTE_ADDRESS:
unleashContextBuilder.remoteAddress(String.valueOf(v));
break;
case CONTEXT_SESSION_ID:
unleashContextBuilder.sessionId(String.valueOf(v));
break;
case CONTEXT_CURRENT_TIME:
unleashContextBuilder.currentTime(ZonedDateTime.parse(String.valueOf(v)));
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
break;
default:
unleashContextBuilder.addProperty(k, String.valueOf(v));
break;
}
});
return unleashContextBuilder.build();
}

/**
* Transform UnleashContext to EvaluationContext.
* @param unleashContext the UnleashContext
* @return transformed EvaluationContext
*/
public static EvaluationContext transform(UnleashContext unleashContext) {
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
Map<String, Value> attributes = new HashMap<>();
unleashContext.getAppName().ifPresent(o -> attributes.put(CONTEXT_APP_NAME, Value.objectToValue(o)));
unleashContext.getUserId().ifPresent(o -> attributes.put(CONTEXT_USER_ID, Value.objectToValue(o)));
unleashContext.getEnvironment().ifPresent(o -> attributes.put(CONTEXT_ENVIRONMENT, Value.objectToValue(o)));
unleashContext.getSessionId().ifPresent(o -> attributes.put(CONTEXT_SESSION_ID, Value.objectToValue(o)));
unleashContext.getRemoteAddress().ifPresent(o -> attributes.put(
CONTEXT_REMOTE_ADDRESS, Value.objectToValue(o)));
unleashContext.getCurrentTime().ifPresent(
o -> attributes.put(CONTEXT_CURRENT_TIME, Value.objectToValue(o.toString())));

unleashContext.getProperties().forEach((k, v) -> {
attributes.put(k, Value.objectToValue(v));
});
return new ImmutableContext(attributes);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package dev.openfeature.contrib.providers.unleash;

import io.getunleash.util.UnleashConfig;
import lombok.Builder;
import lombok.Getter;


/**
* Options for initializing Unleash provider.
*/
@Getter
@Builder
public class UnleashOptions {
private UnleashConfig.Builder unleashConfigBuilder;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,171 @@
package dev.openfeature.contrib.providers.unleash;

import dev.openfeature.sdk.EvaluationContext;
import dev.openfeature.sdk.EventProvider;
import dev.openfeature.sdk.Metadata;
import dev.openfeature.sdk.ProviderEvaluation;
import dev.openfeature.sdk.ProviderEventDetails;
import dev.openfeature.sdk.ProviderState;
import dev.openfeature.sdk.Value;
import dev.openfeature.sdk.exceptions.GeneralError;
import dev.openfeature.sdk.exceptions.ProviderNotReadyError;
import dev.openfeature.sdk.exceptions.TypeMismatchError;
import io.getunleash.DefaultUnleash;
import io.getunleash.Unleash;
import io.getunleash.UnleashContext;
import io.getunleash.Variant;
import io.getunleash.util.UnleashConfig;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.Setter;
import lombok.extern.slf4j.Slf4j;

import java.util.concurrent.atomic.AtomicBoolean;

import static io.getunleash.Variant.DISABLED_VARIANT;

/**
* Provider implementation for Unleash.
*/
@Slf4j
public class UnleashProvider extends EventProvider {

@Getter
private static final String NAME = "Unleash Provider";
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
public static final String NOT_IMPLEMENTED =
"Not implemented - provider does not support this type. Only boolean is supported.";
toddbaert marked this conversation as resolved.
Show resolved Hide resolved

public static final String PROVIDER_NOT_YET_INITIALIZED = "provider not yet initialized";
public static final String UNKNOWN_ERROR = "unknown error";

@Getter(AccessLevel.PROTECTED)
private UnleashOptions unleashOptions;

@Setter(AccessLevel.PROTECTED)
@Getter
private Unleash unleash;

@Setter(AccessLevel.PROTECTED)
@Getter
private ProviderState state = ProviderState.NOT_READY;

private AtomicBoolean isInitialized = new AtomicBoolean(false);

/**
* Constructor.
* @param unleashOptions UnleashOptions
*/
public UnleashProvider(UnleashOptions unleashOptions) {
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
this.unleashOptions = unleashOptions;
}

/**
* Initialize the provider.
* @param evaluationContext evaluation context
* @throws Exception on error
*/
@Override
public void initialize(EvaluationContext evaluationContext) throws Exception {
boolean initialized = isInitialized.getAndSet(true);
if (initialized) {
throw new GeneralError("already initialized");
}
super.initialize(evaluationContext);
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
UnleashSubscriberWrapper unleashSubscriberWrapper = new UnleashSubscriberWrapper(
unleashOptions.getUnleashConfigBuilder().build().getSubscriber(), this);
unleashOptions.getUnleashConfigBuilder().subscriber(unleashSubscriberWrapper);
UnleashConfig unleashConfig = unleashOptions.getUnleashConfigBuilder().build();
unleash = new DefaultUnleash(unleashConfig);

// else, state will be changed via UnleashSubscriberWrapper events
if (unleashConfig.isSynchronousFetchOnInitialisation()) {
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
state = ProviderState.READY;
} else {
log.info("ready state will be changed via UnleashSubscriberWrapper events");
}

log.info("finished initializing provider, state: {}", state);
}

@Override
public Metadata getMetadata() {
return () -> NAME;
}

@Override
public void emitProviderReady(ProviderEventDetails details) {
super.emitProviderReady(details);
state = ProviderState.READY;
}

@Override
public void emitProviderError(ProviderEventDetails details) {
super.emitProviderError(details);
state = ProviderState.ERROR;
}

@Override
public ProviderEvaluation<Boolean> getBooleanEvaluation(String key, Boolean defaultValue, EvaluationContext ctx) {
if (!ProviderState.READY.equals(state)) {
if (ProviderState.NOT_READY.equals(state)) {
throw new ProviderNotReadyError(PROVIDER_NOT_YET_INITIALIZED);
}
throw new GeneralError(UNKNOWN_ERROR);
}
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
UnleashContext context = ctx == null ? UnleashContext.builder().build() : ContextTransformer.transform(ctx);
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
boolean featureBooleanValue = unleash.isEnabled(key, context, defaultValue);
return ProviderEvaluation.<Boolean>builder()
.value(featureBooleanValue)
.build();
}

@Override
public ProviderEvaluation<String> getStringEvaluation(String key, String defaultValue, EvaluationContext ctx) {
if (!ProviderState.READY.equals(state)) {
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
if (ProviderState.NOT_READY.equals(state)) {
throw new ProviderNotReadyError(PROVIDER_NOT_YET_INITIALIZED);
}
throw new GeneralError(UNKNOWN_ERROR);
}
UnleashContext context = ctx == null ? UnleashContext.builder().build() : ContextTransformer.transform(ctx);
Variant evaluatedVariant = unleash.getVariant(key, context);
String variantName;
String value;
if (DISABLED_VARIANT.equals(evaluatedVariant)) {
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
variantName = null;
value = defaultValue;
} else {
variantName = evaluatedVariant.getName();
value = evaluatedVariant.getPayload().get().getValue();
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
}
return ProviderEvaluation.<String>builder()
.value(value)
.variant(variantName)
.build();
}

@Override
public ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defaultValue, EvaluationContext ctx) {
throw new TypeMismatchError(NOT_IMPLEMENTED);
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
}

@Override
public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx) {
throw new TypeMismatchError(NOT_IMPLEMENTED);
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
}

@Override
public ProviderEvaluation<Value> getObjectEvaluation(String s, Value value, EvaluationContext evaluationContext) {
throw new TypeMismatchError(NOT_IMPLEMENTED);
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
}

@Override
public void shutdown() {
super.shutdown();
log.info("shutdown");
if (unleash != null) {
unleash.shutdown();
}
state = ProviderState.NOT_READY;
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
}
}
Loading
Loading