-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flagd in process offline mode #473
Merged
Kavindu-Dodan
merged 12 commits into
open-feature:main
from
Kavindu-Dodan:feat/flagd-in-proc-offline
Oct 9, 2023
Merged
feat: flagd in process offline mode #473
Kavindu-Dodan
merged 12 commits into
open-feature:main
from
Kavindu-Dodan:feat/flagd-in-proc-offline
Oct 9, 2023
+198
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisthat
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left only minor suggestions 👍
...enfeature/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnector.java
Outdated
Show resolved
Hide resolved
.../flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/TestUtils.java
Outdated
Show resolved
Hide resolved
...ature/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnectorTest.java
Outdated
Show resolved
Hide resolved
Kavindu-Dodan
force-pushed
the
feat/flagd-in-proc-offline
branch
from
October 9, 2023 15:08
d4a0f99
to
77fb32b
Compare
toddbaert
reviewed
Oct 9, 2023
toddbaert
reviewed
Oct 9, 2023
toddbaert
reviewed
Oct 9, 2023
...enfeature/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnector.java
Show resolved
Hide resolved
toddbaert
approved these changes
Oct 9, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…s/flagd/resolver/process/storage/connector/file/FileConnector.java Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
…s/flagd/resolver/process/TestUtils.java Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
…s/flagd/resolver/process/storage/connector/file/FileConnectorTest.java Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Kavindu-Dodan
force-pushed
the
feat/flagd-in-proc-offline
branch
from
October 9, 2023 22:30
0854fd4
to
2edeaf4
Compare
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Introduce offline mode for in-process resolver.
The offline mode works with flags read from a local file,
This implementation is kept minimal such that the file is read once at the initialization. No attempt is made to detect file changes. However, the
Connector
contract is flexible for such improvements if we see the need