Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set flag key on $flagd.flagKey #492

Merged
merged 5 commits into from
Oct 13, 2023
Merged

fix: set flag key on $flagd.flagKey #492

merged 5 commits into from
Oct 13, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Oct 13, 2023

As per flagd spec, flag key should be injected into the $flagd props bucket.

  • moved flag key to correct location
  • updated associated code
  • added tests asserting location

All existing tests (including fractional integration tests) pass.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert changed the title fix: flag key on $flagd.flagKey fix: set flag key on $flagd.flagKey Oct 13, 2023
Copy link
Collaborator

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thanks for fixing this

@toddbaert toddbaert merged commit 934f934 into main Oct 13, 2023
5 checks passed
@toddbaert toddbaert deleted the fix/flag-key-location branch October 13, 2023 18:07
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…pen-feature#492)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants