Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extra dimensions to error #497

Merged

Conversation

Kavindu-Dodan
Copy link
Collaborator

This PR

Improves extraAttributes option for both metrics and traces hook by including extra attributes (dimensions) to error traces/metrics.

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner October 13, 2023 17:46
@Kavindu-Dodan Kavindu-Dodan changed the title Feat/extra dimensions to error feat: extra dimensions to error Oct 13, 2023
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry I missed this last time.

hooks/open-telemetry/README.md Outdated Show resolved Hide resolved
hooks/open-telemetry/README.md Outdated Show resolved Hide resolved
Kavindu-Dodan and others added 2 commits October 13, 2023 11:12
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
@Kavindu-Dodan Kavindu-Dodan merged commit b8e852c into open-feature:main Oct 13, 2023
4 checks passed
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…ure#497)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants