Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flagd provider implementation #66

Merged
merged 6 commits into from
Aug 31, 2022
Merged

feat: add flagd provider implementation #66

merged 6 commits into from
Aug 31, 2022

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Aug 17, 2022 •
edited
Loading

  • adding grpc generation for flagd communication (git submodule pull of schemas repo in maven exec plugin)
  • provider implementation
  • tests

@toddbaert toddbaert marked this pull request as draft August 17, 2022 20:39
@beeme1mr beeme1mr linked an issue Aug 25, 2022 that may be closed by this pull request
flagD Java Provider #68
Closed
@toddbaert toddbaert force-pushed the feat/flagd-communication branch 8 times, most recently from 953a035 to 27c08d1 Compare August 31, 2022 01:38
@toddbaert toddbaert marked this pull request as ready for review August 31, 2022 01:38
@toddbaert toddbaert requested a review from skyerus August 31, 2022 01:41
justinabrahms
justinabrahms reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@justinabrahms justinabrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh, this didn't look fun to write. :-/

eclipse-java-google-style.xml.bak Outdated Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Outdated Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Show resolved Hide resolved
@toddbaert
Copy link
Member Author

@justinabrahms

Tbh, this didn't look fun to write. :-/

It wasn't at first, but the SDK changes around the JSON values made it SO MUCH BETTER, I said as much to @beeme1mr earlier. Dealing with the generated protobuf code is a bit tedious, but overall it saves you from writing a ridiculous amount of boilderplate. If you look in target/generated-sources/ you can see how much java is generated from the protobuf spec.

@toddbaert toddbaert force-pushed the feat/flagd-communication branch 3 times, most recently from b8512bb to 3fb7bb3 Compare August 31, 2022 17:04
@toddbaert
feat: add flagd provider implementation
0e969ee 
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
add test for reason handling
234fa20 
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
Add more doc to readme
2d48e11 
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
Make protocol enum
235b158 
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
use provided scope for javasdk
701c380 
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
Extract defaults to vars
254dc71 
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert merged commit 8d299c4 into main Aug 31, 2022
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Merged
@beeme1mr beeme1mr deleted the feat/flagd-communication branch September 2, 2022 13:18
This was referenced Sep 16, 2022
Merged
Closed
toddbaert added a commit to toddbaert/java-sdk-contrib that referenced this pull request Sep 26, 2022
@james-milligan @beeme1mr
@thomaspoignant @toddbaert
feat: flagd provider (open-feature#66)
9d6cb86 
* initial commit

Signed-off-by: James-Milligan <james@omnant.co.uk>

* nx format:write

Signed-off-by: James-Milligan <james@omnant.co.uk>

* udpated nxignore to exclude generated files

Signed-off-by: James-Milligan <james@omnant.co.uk>

* fixed linting issues

Signed-off-by: James-Milligan <james@omnant.co.uk>

* typo

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed nested .vscode

Signed-off-by: James-Milligan <james@omnant.co.uk>

* added typing to axios response objects

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed proto files from version control

Signed-off-by: James-Milligan <james@omnant.co.uk>

* required commit for nx run-command

Signed-off-by: James-Milligan <james@omnant.co.uk>

* actions

Signed-off-by: James-Milligan <james@omnant.co.uk>

* dependency updates + removal of cantextTransformer method

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed forked submodule

Signed-off-by: James-Milligan <james@omnant.co.uk>

* switched to open-feature/schemas

Signed-off-by: James-Milligan <james@omnant.co.uk>

* dependency sync

Signed-off-by: James-Milligan <james@omnant.co.uk>

* merge fixes

Signed-off-by: James-Milligan <james@omnant.co.uk>

* workspace fixes

Signed-off-by: James-Milligan <james@omnant.co.uk>

* merge fixes

Signed-off-by: James-Milligan <james@omnant.co.uk>

* merge fixes

Signed-off-by: James-Milligan <james@omnant.co.uk>

* merge fixes - added go to ci

Signed-off-by: James-Milligan <james@omnant.co.uk>

* merge fixes

Signed-off-by: James-Milligan <james@omnant.co.uk>

* updated go version in github action setup

Signed-off-by: James-Milligan <james@omnant.co.uk>

* squashed commits

Signed-off-by: James-Milligan <james@omnant.co.uk>

* buf setup test => avoid using go install buf

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed go setup + removed submodule issue => error

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed go setup + removed submodule issue => error

Signed-off-by: James-Milligan <james@omnant.co.uk>

* happy path unit tests

Signed-off-by: James-Milligan <james@omnant.co.uk>

* more unit tests + fixes

Signed-off-by: James-Milligan <james@omnant.co.uk>

* set noImplicitOverride to false

Signed-off-by: James-Milligan <james@omnant.co.uk>

* errorCode consolidation

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed tslint ignores and .vscode files

Signed-off-by: James-Milligan <james@omnant.co.uk>

* package.json cleanup

Signed-off-by: James-Milligan <james@omnant.co.uk>

* Update project.json

Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>

* PR updates

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed makefile

Signed-off-by: James-Milligan <james@omnant.co.uk>

* replaced hardcoded errorCode and reason values with imported values from nodesdk

Signed-off-by: James-Milligan <james@omnant.co.uk>

* style updates, simplification of provider construction, README updates

Signed-off-by: James-Milligan <james@omnant.co.uk>

* removed variant value "default_value" on error/default, simplified checkResponse function

Signed-off-by: James-Milligan <james@omnant.co.uk>

* Update README.md

Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>

* Update libs/providers/flagd/package.json

Co-authored-by: Thomas Poignant <thomas.poignant@gmail.com>
Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>

* added encodeURI to urls in http service

Signed-off-by: James-Milligan <james@omnant.co.uk>

* Update pushlish script

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* encodeURIComponent(flagKey) in http service

Signed-off-by: James-Milligan <james@omnant.co.uk>

* added protocol option

Signed-off-by: James-Milligan <james@omnant.co.uk>

* update README

Signed-off-by: James-Milligan <james@omnant.co.uk>

Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Co-authored-by: Thomas Poignant <thomas.poignant@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@toddbaert
chore: Add release plz (open-feature#66)
7e38e54 
* Add release plz

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* Update release doc

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* Add notes about adding release content

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinabrahms justinabrahms justinabrahms approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@james-milligan james-milligan Awaiting requested review from james-milligan

@skyerus skyerus Awaiting requested review from skyerus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flagD Java Provider
3 participants
@toddbaert @justinabrahms @beeme1mr