Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow overrides for fractional seed #737

Merged

Conversation

colebaileygit
Copy link
Contributor

@colebaileygit colebaileygit commented Apr 3, 2024

This PR

  • updates fractional operator for in-process evaluation to allow overriding seed
  • improves e2e test suite setup for development
    • includes docker-compose to setup all 4 flagd sidecars
    • removes hard-coded localhost so that this can be overridden using FLAGD_HOST var

Related Issues

open-feature/flagd#1264

Notes

Unit tests and in-process e2e test suites pass.
RPC e2e test suite still failing since the testbed is still using golang version without the fix.

Follow-up Tasks

How to test

mvn test
cd providers/flagd
docker-compose up -d
mvn test -P e2e

Signed-off-by: Cole Bailey <cole.bailey@deliveryhero.com>
@Kavindu-Dodan
Copy link
Collaborator

@colebaileygit thanks for the PR. Yes, this is a special situation (a breaking change in the evaluation core) where we have to wait for flagd release so that e2e tests can use the latest flagd instance. I think we could release flagd within this week so this too can get merged soon.

colebaileygit and others added 7 commits April 11, 2024 09:09
Signed-off-by: Cole Bailey <cole.bailey@deliveryhero.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…9.1.0 (open-feature#736)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…plugin to v3.3.1 (open-feature#738)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…ature#740)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/fractional-custom-seed branch from 28e3784 to 5050ee0 Compare April 11, 2024 16:09
Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
@Kavindu-Dodan
Copy link
Collaborator

@colebaileygit build is green with updated test setu[ 🙌

@Kavindu-Dodan
Copy link
Collaborator

Related - Go Provider update - open-feature/go-sdk-contrib#495

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @colebaileygit . Thanks so much.

@Kavindu-Dodan Kavindu-Dodan merged commit ab6b888 into open-feature:main Apr 11, 2024
4 checks passed
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…t to cc61a07 (open-feature#737)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants