Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use namespaced schemas for flagd json schemas (#843) #850

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat: use namespaced schemas for flagd json schemas (#843) #850

merged 1 commit into from
Jun 28, 2024

Conversation

mehtasankets
Copy link
Contributor

feat: use namespaced schemas for flagd json schemas

Use namespaced schemas for flags and targeting json schemas

Related Issues

Fixes #843

Notes

  • Update build file to copy over schema files to src/main/resources/flagd/schemas/ instead of src/main/resources/
  • Refer targeting.json and flags.json from src/main/resources/flagd/schemas/
  • No new tests are added as existing tests should be sufficient to validate the feature
  • Verified the new location of the schema files by building and extracting the jar locally

@mehtasankets mehtasankets requested a review from a team as a code owner June 28, 2024 10:06
@mehtasankets
feat: use namespaced schemas for flagd json schemas (open-feature#843)
da82b2c 
Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
@mehtasankets mehtasankets mentioned this pull request Jun 28, 2024
Closed
Kavindu-Dodan
Kavindu-Dodan approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Validated locally and it works 🙌

@toddbaert
Copy link
Member

Thanks @mehtasankets !

@toddbaert toddbaert merged commit efc3a9e into open-feature:main Jun 28, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Merged
@Kavindu-Dodan Kavindu-Dodan added this to the flagd-0.8.4 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

@thisthat thisthat Awaiting requested review from thisthat

Assignees

@beeme1mr beeme1mr

@thisthat thisthat

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
flagd-0.8.4
Development

Successfully merging this pull request may close these issues.

[Improvement] flagd json schema files should be namespaced under resources
5 participants
@mehtasankets @toddbaert @Kavindu-Dodan @beeme1mr @thisthat