chore: Create docker-compose.yml do match CONTRIBUTING.md #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
sideshowcoder
changed the title
sideshowcoder
force-pushed
the
sideshowcoder/flagd-docker-compose
branch
2 times, most recently
from
27cf5cf
to
590b5b0
Compare
Signed-off-by: Philipp Fehre <philipp.fehre@mollie.com>
sideshowcoder
force-pushed
the
sideshowcoder/flagd-docker-compose
branch
from
590b5b0
to
53ee77d
Compare
sideshowcoder
changed the title
|
@beeme1mr or @toddbaert any chance you can have a look at this / what is the best way to provide contributions? |
beeme1mr
approved these changes
Aug 26, 2024
|
Hey @sideshowcoder, sorry for the delay. The change looks good, thanks! For small changes, feel free to open a PR directly. We try and keep track of new PRs and review them ASAP but sometimes they get lost in the sea of notifications. If that happens, feel free to ping someone here or on the CNCF Slack workspace. For larger changes, please create an issue first. That way we can align on the requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md mentions to use docker compose to run flagd from the testbed, but there is no
docker-compose.ymlfile present. This PR add it such that it uses the testbed flagdDOCKERFILE.