-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use sdk-maintained state, require 1.12 #964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c417290
to
83db67f
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
83db67f
to
9ca7904
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
liran2000
approved these changes
Sep 24, 2024
aepfli
approved these changes
Sep 24, 2024
beeme1mr
approved these changes
Sep 24, 2024
UtkarshSharma2612
approved these changes
Sep 24, 2024
Kavindu-Dodan
approved these changes
Sep 24, 2024
@thomaspoignant do you have any concerns with this? |
thomaspoignant
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ProviderState
from providers - the SDK now keeps track of this so providers do not have toNothing here is breaking for consumers, it's a transparent change with the exception they will have to update their SDK version.
see: open-feature/java-sdk#1096