-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README to be auto-included in openfeature.dev #560
Conversation
Codecov Report
@@ Coverage Diff @@
## main #560 +/- ##
============================================
+ Coverage 94.25% 94.49% +0.23%
- Complexity 356 357 +1
============================================
Files 32 32
Lines 835 835
Branches 50 50
============================================
+ Hits 787 789 +2
+ Misses 27 26 -1
+ Partials 21 20 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4981365
to
9cd40cd
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
9cd40cd
to
788b54e
Compare
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Since you're referencing the in-memory provider, we should wait until the next release is ready to be merged.
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments, but the rest looks solid
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! |
Updating README to conform to auto-inclusion for openfeature.dev