Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README to be auto-included in openfeature.dev #560

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

toddbaert
Copy link
Member

Updating README to conform to auto-inclusion for openfeature.dev

@toddbaert toddbaert requested a review from a team as a code owner August 15, 2023 17:50
@toddbaert toddbaert requested a review from beeme1mr August 15, 2023 17:51
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #560 (a1baac8) into main (1f28921) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #560      +/-   ##
============================================
+ Coverage     94.25%   94.49%   +0.23%     
- Complexity      356      357       +1     
============================================
  Files            32       32              
  Lines           835      835              
  Branches         50       50              
============================================
+ Hits            787      789       +2     
+ Misses           27       26       -1     
+ Partials         21       20       -1     
Flag Coverage Δ
unittests 94.49% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert changed the title chore: update README to be auto-included in openfeatre.dev chore: update README to be auto-included in openfeature.dev Aug 15, 2023
@toddbaert toddbaert changed the title chore: update README to be auto-included in openfeature.dev chore: update README to be auto-included in openfeature.dev Aug 15, 2023
@toddbaert toddbaert changed the title chore: update README to be auto-included in openfeature.dev chore: update README to be auto-included in openfeature.dev Aug 15, 2023
@toddbaert toddbaert force-pushed the chore/update-readme-with-template branch from 4981365 to 9cd40cd Compare August 15, 2023 18:27
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert force-pushed the chore/update-readme-with-template branch from 9cd40cd to 788b54e Compare August 15, 2023 19:34
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
toddbaert and others added 3 commits August 15, 2023 16:28
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from beeme1mr August 15, 2023 20:40
@beeme1mr beeme1mr changed the title chore: update README to be auto-included in openfeature.dev docs: update README to be auto-included in openfeature.dev Aug 15, 2023
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Since you're referencing the in-memory provider, we should wait until the next release is ready to be merged.

#558

README.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments, but the rest looks solid

toddbaert and others added 3 commits August 16, 2023 12:29
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@toddbaert toddbaert merged commit 3496366 into main Aug 16, 2023
@toddbaert toddbaert deleted the chore/update-readme-with-template branch August 16, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants