Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update OpenFeature SDK peer #798

Merged
merged 4 commits into from
Mar 16, 2024
Merged

feat!: update OpenFeature SDK peer #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e023a81
feat: update OpenFeature SDK peer
toddbaert Mar 14, 2024
fcea37c
fixup: use published package
toddbaert Mar 15, 2024
8d2e27e
Merge branch 'main' into feat/update-sdks
toddbaert Mar 15, 2024
0a565a2
Merge branch 'main' into feat/update-sdks
toddbaert Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/hooks/open-telemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.8.0",
"@openfeature/server-sdk": "^1.13.0",
"@opentelemetry/api": ">=1.3.0"
},
"license": "Apache-2.0"
Expand Down
2 changes: 1 addition & 1 deletion libs/providers/config-cat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.8.0",
"@openfeature/server-sdk": "^1.13.0",
"configcat-js-ssr": ">=7.1.2"
}
}
2 changes: 1 addition & 1 deletion libs/providers/env-var/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.8.0"
"@openfeature/server-sdk": "^1.13.0"
}
}
2 changes: 1 addition & 1 deletion libs/providers/flagd-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/web-sdk": "^0.4.0"
"@openfeature/web-sdk": "^1.0.0"
}
}
2 changes: 1 addition & 1 deletion libs/providers/flagd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
},
"peerDependencies": {
"@grpc/grpc-js": "~1.8.0 || ~1.9.0 || ~1.10.0",
"@openfeature/server-sdk": ">=1.8.0"
"@openfeature/server-sdk": "^1.13.0"
}
}
2 changes: 1 addition & 1 deletion libs/providers/flipt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.6.0",
"@openfeature/server-sdk": "^1.13.0",
"@flipt-io/flipt": "^1.0.0"
}
}
2 changes: 1 addition & 1 deletion libs/providers/go-feature-flag-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/web-sdk": "^0.4.0"
"@openfeature/web-sdk": "^1.0.0"
}
}
14 changes: 8 additions & 6 deletions libs/providers/go-feature-flag-web/src/lib/go-feature-flag-web-provider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ describe('GoFeatureFlagWebProvider', () => {
it('should get a valid boolean flag evaluation', async () => {
const flagKey = 'bool_flag';
await OpenFeature.setContext(defaultContext);
OpenFeature.setProvider('test-provider', defaultProvider);
await OpenFeature.setProviderAndWait('test-provider', defaultProvider);
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
const client = await OpenFeature.getClient('test-provider');
await websocketMockServer.connected;
const got = client.getBooleanDetails(flagKey, false);
Expand All @@ -233,7 +233,7 @@ describe('GoFeatureFlagWebProvider', () => {
it('should get a valid string flag evaluation', async () => {
const flagKey = 'string_flag';
await OpenFeature.setContext(defaultContext);
OpenFeature.setProvider('test-provider', defaultProvider);
await OpenFeature.setProviderAndWait('test-provider', defaultProvider);
const client = await OpenFeature.getClient('test-provider');
await websocketMockServer.connected;
const got = client.getStringDetails(flagKey, 'false');
Expand All @@ -252,7 +252,7 @@ describe('GoFeatureFlagWebProvider', () => {
it('should get a valid number flag evaluation', async () => {
const flagKey = 'number_flag';
await OpenFeature.setContext(defaultContext);
OpenFeature.setProvider('test-provider', defaultProvider);
await OpenFeature.setProviderAndWait('test-provider', defaultProvider);
const client = await OpenFeature.getClient('test-provider');
await websocketMockServer.connected;
const got = client.getNumberDetails(flagKey, 456);
Expand All @@ -271,7 +271,7 @@ describe('GoFeatureFlagWebProvider', () => {
it('should get a valid object flag evaluation', async () => {
const flagKey = 'object_flag';
await OpenFeature.setContext(defaultContext);
OpenFeature.setProvider('test-provider', defaultProvider);
await OpenFeature.setProviderAndWait('test-provider', defaultProvider);
const client = await OpenFeature.getClient('test-provider');
await websocketMockServer.connected;
const got = client.getObjectDetails(flagKey, { error: true });
Expand All @@ -290,7 +290,7 @@ describe('GoFeatureFlagWebProvider', () => {
it('should get an error if evaluate a boolean flag with a string function', async () => {
const flagKey = 'bool_flag';
await OpenFeature.setContext(defaultContext);
OpenFeature.setProvider('test-provider', defaultProvider);
await OpenFeature.setProviderAndWait('test-provider', defaultProvider);
const client = await OpenFeature.getClient('test-provider');
await websocketMockServer.connected;
const got = client.getStringDetails(flagKey, 'false');
Expand All @@ -308,7 +308,7 @@ describe('GoFeatureFlagWebProvider', () => {
it('should get an error if flag does not exists', async () => {
const flagKey = 'not-exist';
await OpenFeature.setContext(defaultContext);
OpenFeature.setProvider('test-provider', defaultProvider);
await OpenFeature.setProviderAndWait('test-provider', defaultProvider);
const client = await OpenFeature.getClient('test-provider');
await websocketMockServer.connected;
const got = client.getBooleanDetails(flagKey, false);
Expand Down Expand Up @@ -382,7 +382,9 @@ describe('GoFeatureFlagWebProvider', () => {
expect(staleHandler).not.toBeCalled();
expect(configurationChangedHandler.mock.calls[0][0]).toEqual({
clientName: 'test-provider',
domain: 'test-provider',
message: 'flag configuration have changed',
providerName: 'GoFeatureFlagWebProvider',
flagsChanged: [
'deleted-flag-1',
'deleted-flag-2',
Expand Down
2 changes: 1 addition & 1 deletion libs/providers/go-feature-flag/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.8.0"
"@openfeature/server-sdk": "^1.13.0"
}
}
2 changes: 1 addition & 1 deletion libs/providers/launchdarkly-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/web-sdk": "^0.4.0",
"@openfeature/web-sdk": "^1.0.0",
"launchdarkly-js-client-sdk": ">=3.1.3"
}
}
31 changes: 17 additions & 14 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
"@nx/rollup": "16.9.1",
"@nx/web": "16.9.1",
"@nx/workspace": "16.9.1",
"@openfeature/core": "^0.0.21",
"@openfeature/core": "^1.0.0",
"@openfeature/flagd-core": ">=0.1.10",
"@openfeature/server-sdk": "^1.8.0",
"@openfeature/web-sdk": "^0.4.0",
"@openfeature/server-sdk": "^1.13.2",
"@openfeature/web-sdk": "1.0.0",
"@opentelemetry/sdk-metrics": "^1.15.0",
"@swc-node/register": "~1.8.0",
"@swc/cli": "~0.3.0",
Expand Down
4 changes: 2 additions & 2 deletions tools/workspace-plugin/src/generators/open-feature/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,10 @@ function updatePackage(tree: Tree, projectRoot: string, schema: SchemaOptions) {
json.peerDependencies =
schema.category === 'client'
? {
'@openfeature/web-sdk': '>=0.4.0',
'@openfeature/web-sdk': '^1.0.0',
}
: {
'@openfeature/server-sdk': '^1.6.0',
'@openfeature/server-sdk': '^1.13.0',
};

return json;
Expand Down
Loading