feat: ofep for flagd grpc sync #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
beeme1mr
reviewed
Jan 25, 2023
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
3 tasks
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
beeme1mr
approved these changes
Jan 26, 2023
beeme1mr
reviewed
Jan 30, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
beeme1mr
requested review from
AlexsJones,
james-milligan,
skyerus and
toddbaert
|
small typo but will be a great addition |
james-milligan
approved these changes
Jan 30, 2023
skyerus
reviewed
Jan 31, 2023
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
AloisReitbauer
requested changes
Feb 1, 2023
AlexsJones
reviewed
Feb 1, 2023
Kavindu-Dodan
force-pushed
the
ofep/flagd-grpc-sync
branch
from
f047e9d
to
dd3f617
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
ofep/flagd-grpc-sync
branch
from
dd3f617
to
851bcd5
Compare
|
@AloisReitbauer @AlexsJones please let me know if you have any other concerns. I think this is an important OFEP because a gRPC sync would allow users to deploy flagd anywhere while still benefiting from near real-time flag updates. It also won't introduce additional dependencies because gRPC is already used in the project. There's also interest in the feature from the community, further validating the usefulness of this enhancement. |
AloisReitbauer
approved these changes
Feb 3, 2023
AlexsJones
approved these changes
Feb 3, 2023
beeme1mr
pushed a commit
to open-feature/flagd
that referenced
this pull request
Feb 7, 2023
@Kavindu-Dodan has contributed multiple significant changes and proposals to flagd: - multiple refactors: #291, #307 - ci/security improvements: #338, #337 - architectural proposals (some of which got some attention from outside parties!): open-feature/ofep#45, open-feature/flagd-schemas#78, #249 (comment) - load testing: #225 - documentation improvements For these reasons, I believe he should be made a CODEOWNER in this repository. NOTE: before this is merged, @Kavindu-Dodan should be added with at least `maintainer` permissions to the repo. Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
added a commit
to open-feature/flagd-schemas
that referenced
this pull request
Feb 7, 2023
## This PR Is related to open-feature/ofep#45 & open-feature/flagd#297 Introduce the service contract of grpc sync. Consider checking my personal buf repository - https://buf.build/kavindudodan/flagd for a preview --------- Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Skye Gill <gill.skye95@gmail.com> Co-authored-by: Todd Baert <toddbaert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Provide an OFEP to introduce GRPC sync support for flagd.
Related to open-feature/flagd#249